public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/109310] New: --enable-link-mutex is quite duplicate to --enable-link-serialization
Date: Tue, 28 Mar 2023 04:16:23 +0000	[thread overview]
Message-ID: <bug-109310-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109310

            Bug ID: 109310
           Summary: --enable-link-mutex is quite duplicate to
                    --enable-link-serialization
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org, rguenth at gcc dot gnu.org
  Target Milestone: ---

As mentioned in PR96794, --enable-link-mutex is problematic from LTO point of
view as each linker invocation holds a jobserver token, and thus LTRANS phase
runs with a limited number of jobs.

On the other hand, --enable-link-serialization works fine:
https://gist.githubusercontent.com/marxin/13895e6614c1d73301d05005ed4475b7/raw/bc5eb701024f3d0b912e4e3fb58b96e7abae327c/gcc13-serial-linking.svg

So my question is if we can drop --enable-link-mutex? Note the
--enable-link-serialization option is more generic as it accepts an option
argument (N).

I see only a minimal benefit of --enable-link-mutex and that's the fact it
periodically prints a message that it attempts to acquire a lock. That can be
useful for builder timeout when it comes to a very slow machine. But still, we
should be able to link a FE in a reasonable amount of time.

Jakub, what do you think?

             reply	other threads:[~2023-03-28  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  4:16 marxin at gcc dot gnu.org [this message]
2023-03-28  5:50 ` [Bug bootstrap/109310] " jakub at gcc dot gnu.org
2023-03-29 13:00 ` marxin at gcc dot gnu.org
2023-03-29 13:05 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109310-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).