From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id C1BA03858CDA; Thu, 30 Mar 2023 07:14:28 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1BA03858CDA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1680160468;
	bh=2EN+DXddzaiFmBoVokmNctFj6v0fNB6LcAfjJfCl0FE=;
	h=From:To:Subject:Date:From;
	b=THgxf0I4Ae3F6gBApt4RIAL/ZQltytDKsHlhTl+PK+LSpjSxobgDLu1EjBBSRwsIY
	 gsb6mPtiOEZ534JZW7SRs9PWqwJgte85Zco0bKDR1hH+Eenv04Q/NoF/gWjySy0GmA
	 4w4LV1V+sf7t6BWqtsn1Z0//30/U5g8fT0gL9F4U=
From: "jiangning.liu at amperecomputing dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/109343] New: invalid if conversion
 optimization for aarch64
Date: Thu, 30 Mar 2023 07:14:28 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: rust/master
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jiangning.liu at amperecomputing dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-109343-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109343

            Bug ID: 109343
           Summary: invalid if conversion optimization for aarch64
           Product: gcc
           Version: rust/master
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jiangning.liu at amperecomputing dot com
  Target Milestone: ---

For this small case, if-conversion optimization in back-end generated csel
instruction for aarch64, which is unsafe. The address of variable sga_var c=
ould
be invalid if sga_mapped is false.

$ cat ttt2.c
extern int sga_mapped, sga_var;
int func(int j){
        int i=3D0;
        if(sga_mapped)
                i=3Di+sga_var;
        return i;
}
$ gcc -O3 -S ttt2.c
$ cat ttt2.s
        .arch armv8-a
        .file   "ttt2.c"
        .text
        .align  2
        .p2align 4,,11
        .global func
        .type   func, %function
func:
.LFB0:
        .cfi_startproc
        adrp    x0, sga_mapped
        adrp    x1, sga_var
        ldr     w0, [x0, #:lo12:sga_mapped]
        ldr     w1, [x1, #:lo12:sga_var]
        cmp     w0, 0
        csel    w0, w1, w0, ne
        ret
        .cfi_endproc
.LFE0:
        .size   func, .-func
        .ident  "GCC: (GNU) 12.2.1 20221121 (Red Hat 12.2.1-4)"
        .section        .note.GNU-stack,"",@progbits

For x86, the following code is generated. It is safe because the memory acc=
ess
to sga_var(%rip) won't be really triggered if %eax is not set. Here x86 and
aarch64 are different.

$ cat ttt2.s
        .file   "ttt2.c"
        .text
        .p2align 4
        .globl  func
        .type   func, @function
func:
.LFB0:
        .cfi_startproc
        endbr64
        movl    sga_mapped(%rip), %eax
        testl   %eax, %eax
        cmovne  sga_var(%rip), %eax
        ret=