From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9527A39502F3; Wed, 3 May 2023 15:23:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9527A39502F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683127395; bh=4zo7cbPlZbODbA8knh2g9/uJD+nuQrRrj5EL2N8V3+I=; h=From:To:Subject:Date:In-Reply-To:References:From; b=jvA6Qv1kdnVb+IvUxI2zYh0c9KEQBCTw+In31iPCAsOl68i3hdyFJE78/K8C0A1ng gzVK6/2wezbBjRxI+ppYTR3h1myZi669hS18pjImAcdVRxd9tKGpwp1SBaxpWEDDj/ v2Sk59AK42FCp/8b8ZHVebL8LJb+46J7aJHbKMBs= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109410] [13/14 Regression] ICE: verify_flow_info failed Date: Wed, 03 May 2023 15:23:14 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: compare-debug-failure, ice-checking, ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: REOPENED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.2 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109410 --- Comment #17 from CVS Commits --- The releases/gcc-10 branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:dc457bc1c72c53ee8c4800bac84264e0c8085f24 commit r10-11385-gdc457bc1c72c53ee8c4800bac84264e0c8085f24 Author: Jakub Jelinek Date: Wed Apr 12 16:55:15 2023 +0200 reassoc: Fix up another ICE with returns_twice call [PR109410] The following testcase ICEs in reassoc, unlike the last case I've fixed there here SSA_NAME_USED_IN_ABNORMAL_PHI is not the case anywhere. build_and_add_sum places new statements after the later appearing definition of an operand but if both operands are default defs or constants, we pl= ace statement at the start of the function. If the very first statement of a function is a call to returns_twice function, this doesn't work though, because that call has to be the fir= st thing in its basic block, so the following patch splits the entry succe= ssor edge such that the new statements are added into a different block from= the returns_twice call. I think we should in stage1 reconsider such placements, I think it unnecessarily enlarges the lifetime of the new lhs if its operand(s) are used more than once in the function. Unless something sinks those again. Would be nice to place it closer to the actual uses (or where they will be placed). 2023-04-12 Jakub Jelinek PR tree-optimization/109410 * tree-ssa-reassoc.c (build_and_add_sum): Split edge from entry block if first statement of the function is a call to returns_t= wice function. * gcc.dg/pr109410.c: New test. (cherry picked from commit 51856718a82ce60f067910d9037ca255645b37eb)=