public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109443] missed optimization of std::vector access (Related to issue 35269)
Date: Thu, 13 Apr 2023 08:04:53 +0000	[thread overview]
Message-ID: <bug-109443-4-dIwNntJhnt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109443-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109443

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Making the reference types to return or parameter non-POD types passed by value
restrict could be
--- gcc/cp/call.cc.jj   2023-03-30 09:34:05.609725768 +0200
+++ gcc/cp/call.cc      2023-04-13 09:56:53.226908996 +0200
@@ -9223,7 +9223,11 @@ type_passed_as (tree type)
 {
   /* Pass classes with copy ctors by invisible reference.  */
   if (TREE_ADDRESSABLE (type))
-    type = build_reference_type (type);
+    {
+      type = build_reference_type (type);
+      type = build_qualified_type (type,
+                                  TYPE_QUALS (type) | TYPE_QUAL_RESTRICT);
+    }
   else if (targetm.calls.promote_prototypes (NULL_TREE)
           && INTEGRAL_TYPE_P (type)
           && COMPLETE_TYPE_P (type)
--- gcc/cp/cp-gimplify.cc.jj    2023-03-15 15:36:02.500430556 +0100
+++ gcc/cp/cp-gimplify.cc       2023-04-13 09:57:51.989059798 +0200
@@ -2000,6 +2000,9 @@ cp_genericize (tree fndecl)
     {
       t = DECL_RESULT (fndecl);
       TREE_TYPE (t) = build_reference_type (TREE_TYPE (t));
+      TREE_TYPE (t)
+       = build_qualified_type (TREE_TYPE (t), TYPE_QUALS (TREE_TYPE (t))
+                                              | TYPE_QUAL_RESTRICT);
       DECL_BY_REFERENCE (t) = 1;
       TREE_ADDRESSABLE (t) = 0;
       relayout_decl (t);

Completely untested.  Does this what we want?  Stage1 material anyway...

  parent reply	other threads:[~2023-04-13  8:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 19:31 [Bug tree-optimization/109443] New: " hiraditya at msn dot com
2023-04-06 19:32 ` [Bug tree-optimization/109443] " hiraditya at msn dot com
2023-04-07  6:51 ` xry111 at gcc dot gnu.org
2023-04-07  6:53 ` xry111 at gcc dot gnu.org
2023-04-07  6:54 ` pinskia at gcc dot gnu.org
2023-04-07  6:55 ` pinskia at gcc dot gnu.org
2023-04-11 10:16 ` [Bug c++/109443] " rguenth at gcc dot gnu.org
2023-04-12 15:10 ` jakub at gcc dot gnu.org
2023-04-13  6:58 ` rguenther at suse dot de
2023-04-13  7:43 ` redi at gcc dot gnu.org
2023-04-13  8:04 ` jakub at gcc dot gnu.org [this message]
2023-04-13  8:54 ` jakub at gcc dot gnu.org
2023-04-13 12:24 ` rguenth at gcc dot gnu.org
2023-04-13 12:36 ` jakub at gcc dot gnu.org
2023-04-13 13:08 ` rguenther at suse dot de
2023-04-13 13:18 ` jakub at gcc dot gnu.org
2023-04-13 13:27 ` rguenther at suse dot de
2023-06-15 18:04 ` hiraditya at msn dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109443-4-dIwNntJhnt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).