public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hiraditya at msn dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109443] New: missed optimization of std::vector access (Related to issue 35269)
Date: Thu, 06 Apr 2023 19:31:49 +0000	[thread overview]
Message-ID: <bug-109443-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109443

            Bug ID: 109443
           Summary: missed optimization of std::vector access (Related to
                    issue 35269)
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hiraditya at msn dot com
  Target Milestone: ---

here is slightly modified code example from issue #35269. Both accesses are
similar bug different code is generated. the function `h` has better codegen
than `g` for some reason.


$ g++ -O3 -std=c++20 -fno-exceptions

void f(int);

void g(std::vector<int> v)
{
    for (std::vector<int>::size_type i = 0; i < v.size(); i++)
        f( v[ i ] );
}

void h(std::vector<int> v)
{
    for (std::vector<int>::const_iterator i = v.begin(); i != v.end(); ++i)
        f( *i );
}


g(std::vector<int, std::allocator<int> >):
        mov     rdx, QWORD PTR [rdi]
        cmp     QWORD PTR [rdi+8], rdx
        je      .L6
        push    rbp
        mov     rbp, rdi
        push    rbx
        xor     ebx, ebx
        sub     rsp, 8
.L3:
        mov     edi, DWORD PTR [rdx+rbx*4]
        add     rbx, 1
        call    f(int)
        mov     rdx, QWORD PTR [rbp+0]
        mov     rax, QWORD PTR [rbp+8]
        sub     rax, rdx
        sar     rax, 2
        cmp     rbx, rax
        jb      .L3
        add     rsp, 8
        pop     rbx
        pop     rbp
        ret
.L6:
        ret



h(std::vector<int, std::allocator<int> >):
        push    rbp
        push    rbx
        sub     rsp, 8
        mov     rbx, QWORD PTR [rdi]
        cmp     rbx, QWORD PTR [rdi+8]
        je      .L10
        mov     rbp, rdi
.L12:
        mov     edi, DWORD PTR [rbx]
        add     rbx, 4
        call    f(int)
        cmp     QWORD PTR [rbp+8], rbx
        jne     .L12
.L10:
        add     rsp, 8
        pop     rbx
        pop     rbp
        ret

             reply	other threads:[~2023-04-06 19:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 19:31 hiraditya at msn dot com [this message]
2023-04-06 19:32 ` [Bug tree-optimization/109443] " hiraditya at msn dot com
2023-04-07  6:51 ` xry111 at gcc dot gnu.org
2023-04-07  6:53 ` xry111 at gcc dot gnu.org
2023-04-07  6:54 ` pinskia at gcc dot gnu.org
2023-04-07  6:55 ` pinskia at gcc dot gnu.org
2023-04-11 10:16 ` [Bug c++/109443] " rguenth at gcc dot gnu.org
2023-04-12 15:10 ` jakub at gcc dot gnu.org
2023-04-13  6:58 ` rguenther at suse dot de
2023-04-13  7:43 ` redi at gcc dot gnu.org
2023-04-13  8:04 ` jakub at gcc dot gnu.org
2023-04-13  8:54 ` jakub at gcc dot gnu.org
2023-04-13 12:24 ` rguenth at gcc dot gnu.org
2023-04-13 12:36 ` jakub at gcc dot gnu.org
2023-04-13 13:08 ` rguenther at suse dot de
2023-04-13 13:18 ` jakub at gcc dot gnu.org
2023-04-13 13:27 ` rguenther at suse dot de
2023-06-15 18:04 ` hiraditya at msn dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109443-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).