public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "seeson at pku dot edu.cn" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109457] %z[asmSymbolicName] in AssemblerTemplate fails to compile
Date: Sun, 09 Apr 2023 17:08:14 +0000 [thread overview]
Message-ID: <bug-109457-4-j6W0s5DnNq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109457-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109457
lyazj <seeson at pku dot edu.cn> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|INVALID |FIXED
CC| |seeson at pku dot edu.cn
--- Comment #2 from lyazj <seeson at pku dot edu.cn> ---
](In reply to Andrew Pinski from comment #1)
> This has nothing to do with [x] but rather the constraint g and z operand
> modifier.
>
> The g constraint is defined as:
> Any register, memory or immediate integer operand is allowed, except for
> registers that are not general registers.
>
>
>
> So constant 1 will be allowed here.
>
> While the modifier z says:
> z Print the opcode suffix for the size of the current integer operand (one
> of b/w/l/q). %z0 l
>
> Note integer constants don't have a size ...
>
>
> This is the corrected inline-asm:
> template<class T>
> inline T onec_add(T a, T b)
> {
> asm( "add%z[a]\t%[b], %[a]"
> "\n\tadc%z[a]\t$0, %[a]"
> : [a]"+g"(a) // inputs
> : [b]"g"(b) // outputs
> : "cc" // clobbers
> );
> return a;
> }
>
>
>
> Note I see you did the replacement of [a] and [b] in your example but when
> you replaced %z[b], you replaced it with %z0 rather than what it was
> originally which was %z1.
Thanks very much for the quick and concise solution. I'm sorry that I missed
the truth that I could have probably put the modifier `z` on an immediate and
did the substitution that broke the equivalence to the original code. However,
since the modifier is case-sensitive, I suggest revising the error reporting
routines to report the improper modifier 'z' instead of 'Z' looked like a bug.
:)
next prev parent reply other threads:[~2023-04-09 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 16:37 [Bug c++/109457] New: " seeson at pku dot edu.cn
2023-04-09 16:48 ` [Bug target/109457] " pinskia at gcc dot gnu.org
2023-04-09 17:08 ` seeson at pku dot edu.cn [this message]
2023-04-09 17:09 ` pinskia at gcc dot gnu.org
2023-04-09 17:11 ` pinskia at gcc dot gnu.org
2023-04-09 17:14 ` pinskia at gcc dot gnu.org
2023-04-09 17:25 ` seeson at pku dot edu.cn
2023-04-09 17:26 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-109457-4-j6W0s5DnNq@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).