From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 15DE73858C5E; Wed, 12 Apr 2023 14:54:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15DE73858C5E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1681311246;
	bh=Tz9oIChtzLRi4fQwXHTpNtrggQ2PimJmvhagHC1nzrY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=b3q2lCO6vPNSrIjHOStvAnnsKB/LB5pYc+9np7XlkKvZNluN6ZwKNGshDq8SjlNJP
	 0XNsd53YDiXaHzm6aPBO+soZ2lGIW0NNeqq8KwKty+bdQ/8uOuYbSDM259X9wAEYg+
	 bLY1KS2M3a089I2E7K0g7vuyladxeXZcg6DNq5z4=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109458] invalid use 'z' operand modifier in some cases
 mention the 'Z' operand modifier
Date: Wed, 12 Apr 2023 14:54:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109458-4-ex6D1WRuHi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109458-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109458-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109458

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4073ce2c4e5584c1be58fbe76dd66285de2529bb

commit r13-7154-g4073ce2c4e5584c1be58fbe76dd66285de2529bb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 12 16:53:23 2023 +0200

    i386: Fix up z operand modifier diagnostics on inline-asm [PR109458]

    On the following testcase, we emit weird diagnostics.
    User used the z modifier, but diagnostics talks about Z instead.
    This is because z is implemented by doing some stuff and then falling
    through into the Z case.

    The following patch adjusts the Z diagnostics, such that it prints what=
ever
    modifier user actually uses in places which could happen with either
    modifier.

    Furthermore, in case of the non-integer operand used with operand code
%<z%>
    warning the warning location was incorrect (and of function), so I've u=
sed
    warning_for_asm to get it a proper location in case it is a user
inline-asm.

    2023-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/109458
            * config/i386/i386.cc: Include rtl-error.h.
            (ix86_print_operand): For z modifier warning, use warning_for_a=
sm
            if this_is_asm_operands.  For Z modifier errors, use %c and code
            instead of hardcoded Z.

            * gcc.target/i386/pr109458.c: New test.=