[Bug target/109458] New: invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[Bug target/109458] New: invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109458

            Bug ID: 109458
           Summary: invalid use 'z' operand modifier in some cases mention
                    the 'Z' operand modifier
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: x86_64-*-*

The problem here is the code in i386 does this:

case 'z':
...
          if (GET_MODE_CLASS (GET_MODE (x)) == MODE_FLOAT)
            warning (0, "non-integer operand used with operand code %<z%>");
          /* FALLTHRU */

        case 'Z':

...
          else
            {
              output_operand_lossage ("invalid operand type used with "
                                      "operand code 'Z'");
              return;
            }

          output_operand_lossage ("invalid operand size for operand code 'Z'");


So the error messages for 'Z' modifier is shared with 'z' but only references
'Z'.

[Bug target/109458] invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109458

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-04-09
                 CC|                            |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

[Bug target/109458] invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109458

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54822
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54822&action=edit
gcc13-pr109458.patch

Untested fix.

[Bug target/109458] invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109458

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4073ce2c4e5584c1be58fbe76dd66285de2529bb

commit r13-7154-g4073ce2c4e5584c1be58fbe76dd66285de2529bb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 12 16:53:23 2023 +0200

    i386: Fix up z operand modifier diagnostics on inline-asm [PR109458]

    On the following testcase, we emit weird diagnostics.
    User used the z modifier, but diagnostics talks about Z instead.
    This is because z is implemented by doing some stuff and then falling
    through into the Z case.

    The following patch adjusts the Z diagnostics, such that it prints whatever
    modifier user actually uses in places which could happen with either
    modifier.

    Furthermore, in case of the non-integer operand used with operand code
%<z%>
    warning the warning location was incorrect (and of function), so I've used
    warning_for_asm to get it a proper location in case it is a user
inline-asm.

    2023-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR target/109458
            * config/i386/i386.cc: Include rtl-error.h.
            (ix86_print_operand): For z modifier warning, use warning_for_asm
            if this_is_asm_operands.  For Z modifier errors, use %c and code
            instead of hardcoded Z.

            * gcc.target/i386/pr109458.c: New test.

[Bug target/109458] invalid use 'z' operand modifier in some cases mention the 'Z' operand modifier

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109458

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.  Unimportant enough to be not worth backporting.