[Bug c++/109480] [11/12/13/14 Regression] non-depedent access goes wrong in a template method sometimes since r11-1350-g92bed036098928

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109480

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:7f4840ddef9746ab591c78ecdd750e3b18aa1ce6

commit r14-556-g7f4840ddef9746ab591c78ecdd750e3b18aa1ce6
Author: Patrick Palka <ppalka@redhat.com>
Date:   Sun May 7 10:24:49 2023 -0400

    c++: potentiality of templated memfn call [PR109480]

    Here we're incorrectly deeming the templated call a.g() inside b's
    initializer as potentially constant, despite g being non-constexpr,
    which leads to us needlessly instantiating the initializer ahead of time
    and which subsequently triggers a bug in access checking deferral (to be
    fixed by the follow-up patch).

    This patch fixes this by calling get_fns earlier during CALL_EXPR
    potentiality checking so that when we extract a FUNCTION_DECL out of a
    templated member function call (whose overall callee is typically a
    COMPONENT_REF) we do the usual constexpr-eligibility checking for it.

    In passing, I noticed the nearby special handling of the object argument
    of a non-static member function call is effectively the same as the
    generic argument handling a few lines below.  So this patch just gets
    rid of this special handling; otherwise we'd have to adapt it to handle
    templated versions of such calls.

            PR c++/109480

    gcc/cp/ChangeLog:

            * constexpr.cc (potential_constant_expression_1) <case CALL_EXPR>:
            Reorganize to call get_fns sooner.  Remove special handling of
            the object argument of a non-static member function call.  Remove
            dead store to 'fun'.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/noexcept59.C: Make e() constexpr so that the
            expected "without object" diagnostic isn't replaced by a
            "call to non-constexpr function" diagnostic.
            * g++.dg/template/non-dependent25.C: New test.