[Bug c++/109501] New: vec_test_data_class defines missing

[Bug c++/109501] New: vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

            Bug ID: 109501
           Summary: vec_test_data_class defines missing
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chip.kerchner at ibm dot com
  Target Milestone: ---

These defines seems to be missing

#define __VEC_CLASS_FP_NAN (1<<6)
#define __VEC_CLASS_FP_INFINITY_P (1<<5)
#define __VEC_CLASS_FP_INFINITY_N (1<<4)
#define __VEC_CLASS_FP_ZERO_P (1<<3)
#define __VEC_CLASS_FP_ZERO_N (1<<2)
#define __VEC_CLASS_FP_SUBNORMAL_P (1<<1)
#define __VEC_CLASS_FP_SUBNORMAL_N (1<<0)
#define __VEC_CLASS_FP_INFINITY (__VEC_CLASS_FP_INFINITY_P
| __VEC_CLASS_FP_INFINITY_N)
#define __VEC_CLASS_FP_ZERO (__VEC_CLASS_FP_ZERO_P | __VEC_CLASS_FP_ZERO_N)
#define __VEC_CLASS_FP_SUBNORMAL (__VEC_CLASS_FP_SUBNORMAL_P
| __VEC_CLASS_FP_SUBNORMAL_N)
#define __VEC_CLASS_FP_NOT_NORMAL (__VEC_CLASS_FP_NAN |
__VEC_CLASS_FP_SUBNORMAL
| __VEC_CLASS_FP_ZERO | __VEC_CLASS_FP_INFINITY)

[Bug c++/109501] vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

Chip Kerchner <chip.kerchner at ibm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chip.kerchner at ibm dot com

--- Comment #1 from Chip Kerchner <chip.kerchner at ibm dot com> ---
```
  __vector float p4f = some data;

 1645 |   __vector __bool int nan_selector = vec_test_data_class(p4f,
__VEC_CLASS_FP_NAN);
```

[Bug c++/109501] vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

--- Comment #2 from Chip Kerchner <chip.kerchner at ibm dot com> ---
'__VEC_CLASS_FP_NAN' was not declared in this scope

[Bug target/109501] vec_test_data_class defines missing

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |target

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Which target is this for?
If s390 did you include vecintrin.h?

[Bug target/109501] vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

--- Comment #4 from Chip Kerchner <chip.kerchner at ibm dot com> ---
PowerPC LE - P9.

Yes, other PVIPR APIs are available and compile in more source code.

[Bug target/109501] vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

--- Comment #5 from Chip Kerchner <chip.kerchner at ibm dot com> ---
Here's a testcase

```
#include <altivec.h>
#include <stdio.h>

int main()
{
  __vector float p4f = { float(0), float(1), float(2), float(3) };
  __vector __bool int nan_selector = vec_test_data_class(p4f,
__VEC_CLASS_FP_NAN);

  return 0;
}
```

```
NAN_defines.cpp: In function ‘int main()’:
NAN_defines.cpp:7:63: error: ‘__VEC_CLASS_FP_NAN’ was not declared in this
scope
    7 |   __vector __bool int nan_selector = vec_test_data_class(p4f,
__VEC_CLASS_FP_NAN);
      |                                                              
^~~~~~~~~~~~~~~~~~
```

```
/opt/gcc-nightly/trunk/bin/g++ -O3 -mcpu=power9 NAN_defines.cpp

[Bug target/109501] vec_test_data_class defines missing

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |segher at gcc dot gnu.org

--- Comment #6 from Segher Boessenkool <segher at gcc dot gnu.org> ---
None of those are required.  All are optional.  No portable code should use
them.

[Bug target/109501] vec_test_data_class defines missing

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

--- Comment #7 from Segher Boessenkool <segher at gcc dot gnu.org> ---
"For clarity of code, the following named constants are suggested. Preferably,
compilers will provide these constants in a header file, but this is not
required
for compliance."

[Bug target/109501] vec_test_data_class defines missing

[chip.kerchner at ibm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

--- Comment #8 from Chip Kerchner <chip.kerchner at ibm dot com> ---
Well, then I'm asking GCC to add these to make it easier to use
`vec_test_data_class`

[Bug target/109501] rs6000: Add suggested defines for vec_test_data_class

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109501

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-04-13
     Ever confirmed|0                           |1
            Summary|vec_test_data_class defines |rs6000: Add suggested
                   |missing                     |defines for
                   |                            |vec_test_data_class
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW
           Severity|normal                      |enhancement

--- Comment #9 from Segher Boessenkool <segher at gcc dot gnu.org> ---
I marked this as enhancement, and changed the summary.  Thanks!