public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/109510] [13 Regression] bootstrap with Ada broken on aarch64
Date: Fri, 14 Apr 2023 10:40:18 +0000	[thread overview]
Message-ID: <bug-109510-4-ifRzTQU8WX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109510-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109510

--- Comment #9 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> How do you get at the alignment the type would have when the user didn't
> specify it?  That's what the call ABI is supposed to look at.
> 
> /* 1 if the alignment for this type was requested by "aligned" attribute,
>    0 if it is the default for this type.  */
> #define TYPE_USER_ALIGN(NODE) (TYPE_CHECK (NODE)->base.u.bits.user_align)
> 
> so what's the "default" alignment?

Note that the wording is ambiguous if the "aligned" attribute requests the same
alignment as the default for the type, which is the case here:

   type Val is mod 2**Val_Bits with Alignment => Val_Bytes;

The alignment clause is confirming in Ada parlance, which means that it does
not change anything.  We set TYPE_USER_ALIGN in this case, but I agree that we
might as well not set it.  Tentative patch to be attached.

  parent reply	other threads:[~2023-04-14 10:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  8:23 [Bug bootstrap/109510] New: " rguenth at gcc dot gnu.org
2023-04-14  8:24 ` [Bug bootstrap/109510] " rguenth at gcc dot gnu.org
2023-04-14  8:27 ` rguenth at gcc dot gnu.org
2023-04-14  9:04 ` ebotcazou at gcc dot gnu.org
2023-04-14  9:26 ` rguenth at gcc dot gnu.org
2023-04-14  9:27 ` rguenth at gcc dot gnu.org
2023-04-14  9:36 ` jakub at gcc dot gnu.org
2023-04-14  9:58 ` ebotcazou at gcc dot gnu.org
2023-04-14 10:14 ` jakub at gcc dot gnu.org
2023-04-14 10:34 ` rsandifo at gcc dot gnu.org
2023-04-14 10:40 ` ebotcazou at gcc dot gnu.org [this message]
2023-04-14 10:43 ` ebotcazou at gcc dot gnu.org
2023-04-14 11:39 ` rguenth at gcc dot gnu.org
2023-04-14 11:42 ` rsandifo at gcc dot gnu.org
2023-04-14 18:18 ` cvs-commit at gcc dot gnu.org
2023-04-14 18:19 ` ebotcazou at gcc dot gnu.org
2023-04-15 17:39 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109510-4-ifRzTQU8WX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).