public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109539] [13/14 Regression] Compile-time hog in gimple-ssa-warn-access.cc since r13-6706-gadb70c2d1060b3 Date: Tue, 18 Apr 2023 12:38:12 +0000 [thread overview] Message-ID: <bug-109539-4-vTqAL2LGgL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109539-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109539 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:fdbaab2dc886f78a1e75512eeee0faa17e77c862 commit r14-30-gfdbaab2dc886f78a1e75512eeee0faa17e77c862 Author: Richard Biener <rguenther@suse.de> Date: Tue Apr 18 11:49:48 2023 +0200 tree-optimization/109539 - restrict PHI handling in access diagnostics Access diagnostics visits the SSA def-use chains to diagnose things like dangling pointer uses. When that runs into PHIs it tries to prove all incoming pointers of which one is the currently visited use are related to decide whether to keep looking for the PHI def uses. That turns out to be overly optimistic and thus costly. The following scraps the existing handling for simply requiring that we eventually visit all incoming pointers of the PHI during the def-use chain analysis and only then process uses of the PHI def. Note this handles backedges of natural loops optimistically, diagnosing the first iteration. There's gcc.dg/Wuse-after-free-2.c containing a testcase requiring this. PR tree-optimization/109539 * gimple-ssa-warn-access.cc (pass_waccess::check_pointer_uses): Re-implement pointer relatedness for PHIs.
next prev parent reply other threads:[~2023-04-18 12:38 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-18 6:48 [Bug tree-optimization/109539] New: " marxin at gcc dot gnu.org 2023-04-18 6:50 ` [Bug tree-optimization/109539] " marxin at gcc dot gnu.org 2023-04-18 8:22 ` marxin at gcc dot gnu.org 2023-04-18 8:44 ` rguenth at gcc dot gnu.org 2023-04-18 9:12 ` rguenth at gcc dot gnu.org 2023-04-18 9:49 ` rguenth at gcc dot gnu.org 2023-04-18 12:38 ` cvs-commit at gcc dot gnu.org [this message] 2023-04-18 12:38 ` cvs-commit at gcc dot gnu.org 2023-04-18 12:39 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109539-4-vTqAL2LGgL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).