public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/109559] [12/13/14 Regression] Unexpected -Wmaybe-uninitialized warning when inlining with system header
Date: Wed, 19 Apr 2023 20:25:27 +0000	[thread overview]
Message-ID: <bug-109559-4-d5A2E8P7oF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109559-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109559

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unexpected                  |[12/13/14 Regression]
                   |-Wmaybe-uninitialized       |Unexpected
                   |warning when inlining with  |-Wmaybe-uninitialized
                   |system header               |warning when inlining with
                   |                            |system header
           Keywords|                            |diagnostic
   Target Milestone|---                         |12.3

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r12-1992.  

We have an inlining context containing locations for each call site along
the inlining stack: struct inlining_info.  It has a stack of locations,
and a flag that says whether all of them come from a system header.  If so,
we don't warn:

1548   if (!report_warning_p && diagnostic->m_iinfo.m_allsyslocs)
1549     /* Bail if the warning is not to be reported because all locations
1550        in the inlining stack (if there is one) are in system headers.  */
1551     return false;

but in this test diagnostic->m_iinfo.m_allsyslocs is false because the inlining
causes that the outermost context is the un.cc file, which is not a system
header.

It looks like this is a failure to propagate the sysp flag when inlining a
function.

  reply	other threads:[~2023-04-19 20:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 20:23 [Bug middle-end/109559] New: " mpolacek at gcc dot gnu.org
2023-04-19 20:25 ` mpolacek at gcc dot gnu.org [this message]
2023-04-19 20:30 ` [Bug middle-end/109559] [12/13/14 Regression] " mpolacek at gcc dot gnu.org
2023-05-08 12:27 ` rguenth at gcc dot gnu.org
2024-01-12 10:29 ` rguenth at gcc dot gnu.org
2024-02-01 22:12 ` mpolacek at gcc dot gnu.org
2024-02-05 10:45 ` rguenth at gcc dot gnu.org
2024-02-05 12:36 ` rguenth at gcc dot gnu.org
2024-02-05 13:00 ` rguenth at gcc dot gnu.org
2024-02-06  9:53 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109559-4-d5A2E8P7oF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).