public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109566] [12/13/14 Regression] powerpc: unrecognizable insn for -mcpu=e6500, -mcpu=power3, ..., -mcpu=power10
Date: Tue, 25 Apr 2023 12:21:39 +0000	[thread overview]
Message-ID: <bug-109566-4-ADnqrAzTAD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109566-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109566

--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:97f8f2d0a0384d377ca46da88495f9a3d18d4415

commit r14-218-g97f8f2d0a0384d377ca46da88495f9a3d18d4415
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 25 14:20:51 2023 +0200

    powerpc: Fix up *branch_anddi3_dot for -m32 -mpowerpc64 [PR109566]

    The following testcase reduced from newlib ICEs on powerpc-linux,
    with -O2 -m32 -mpowerpc64 since r12-6433 PR102239 optimization was
    added and on the original testcase since some ranger improvements in
    GCC 13 made it no longer latent on newlib.
    The problem is that the *branch_anddi3_dot define_insn_and_split
    relies on the *rotldi3_mask_dot define_insn_and_split being recognized
    during splitting.  The rs6000_is_valid_rotate_dot_mask function checks
whether
    the mask is a CONST_INT which is a valid mask, but *rotl<mode>3_mask_dot in
    addition to checking that it is a valid mask also has
      (<MODE>mode == Pmode || UINTVAL (operands[3]) <= 0x7fffffff)
    test in the condition.  For TARGET_64BIT that doesn't add any further
    requirements, but for !TARGET_64BIT && TARGET_POWERPC64 if the AND
    second operand is larger than INT_MAX it will not be recognized.

    The rs6000_is_valid_rotate_dot_mask function is used solely in one spot,
    condition of *branch_anddi3_dot, so the following patch adjusts it
    to check for that as well.

    2023-04-25  Jakub Jelinek  <jakub@redhat.com>

            PR target/109566
            * config/rs6000/rs6000.cc (rs6000_is_valid_rotate_dot_mask): For
            !TARGET_64BIT, don't return true if UINTVAL (mask) << (63 - nb)
            is larger than signed int maximum.

            * gcc.target/powerpc/pr109566.c: New test.

  parent reply	other threads:[~2023-04-25 12:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  8:34 [Bug target/109566] New: powerpc: unrecognizable insn for -mcpu=e6500 sebastian.huber@embedded-brains.de
2023-04-21  8:34 ` [Bug target/109566] " sebastian.huber@embedded-brains.de
2023-04-21  8:54 ` sebastian.huber@embedded-brains.de
2023-04-24  6:31 ` [Bug target/109566] powerpc: unrecognizable insn for -mcpu=e6500, -mcpu=power3, ..., -mcpu=power10 sebastian.huber@embedded-brains.de
2023-04-24  6:33 ` sebastian.huber@embedded-brains.de
2023-04-24  8:27 ` [Bug target/109566] [13/14 Regression] " rguenth at gcc dot gnu.org
2023-04-24  8:51 ` jakub at gcc dot gnu.org
2023-04-24  9:09 ` sebastian.huber@embedded-brains.de
2023-04-24  9:32 ` jakub at gcc dot gnu.org
2023-04-24  9:50 ` jakub at gcc dot gnu.org
2023-04-24 10:09 ` jakub at gcc dot gnu.org
2023-04-24 10:33 ` jakub at gcc dot gnu.org
2023-04-24 10:37 ` jakub at gcc dot gnu.org
2023-04-24 10:54 ` [Bug target/109566] [12/13/14 " jakub at gcc dot gnu.org
2023-04-24 10:57 ` jakub at gcc dot gnu.org
2023-04-24 11:03 ` sebastian.huber@embedded-brains.de
2023-04-25 12:21 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-25 12:24 ` segher at gcc dot gnu.org
2023-04-25 12:37 ` cvs-commit at gcc dot gnu.org
2023-04-25 14:12 ` [Bug target/109566] [12 " jakub at gcc dot gnu.org
2023-04-25 14:12 ` jakub at gcc dot gnu.org
2023-04-26 10:59 ` cvs-commit at gcc dot gnu.org
2023-04-26 11:00 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109566-4-ADnqrAzTAD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).