public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "vanyacpp at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug analyzer/109570] New: detect fclose on unopened or NULL files Date: Thu, 20 Apr 2023 13:33:46 +0000 [thread overview] Message-ID: <bug-109570-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109570 Bug ID: 109570 Summary: detect fclose on unopened or NULL files Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: analyzer Assignee: dmalcolm at gcc dot gnu.org Reporter: vanyacpp at gmail dot com Target Milestone: --- While cleaning up one not particularly well written program I noticed this code fragment: FILE* file = fopen(...); if (!file) { fclose(file); return false; } Passing NULL to fclose is undefined behavior. Perhaps -fanalyzer could warn about code like this?
next reply other threads:[~2023-04-20 13:33 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-20 13:33 vanyacpp at gmail dot com [this message] 2023-04-20 13:36 ` [Bug analyzer/109570] " vanyacpp at gmail dot com 2023-04-20 21:31 ` dmalcolm at gcc dot gnu.org 2023-05-16 10:20 ` xry111 at gcc dot gnu.org 2023-05-16 20:29 ` clyon at gcc dot gnu.org 2023-05-17 15:03 ` clyon at gcc dot gnu.org 2023-05-17 15:14 ` xry111 at gcc dot gnu.org 2023-08-15 21:00 ` glebfm at altlinux dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109570-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).