public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109583] [13/14 Regression] ICE in related_vector_mode, at stor-layout.cc:537 since r14-22-g2349e69125335d
Date: Sat, 22 Apr 2023 08:33:27 +0000	[thread overview]
Message-ID: <bug-109583-4-Alv0yU5dP4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109583-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109583

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9b6bf076c11cba0f9ccdace63e8b4044b1a858ea

commit r13-7234-g9b6bf076c11cba0f9ccdace63e8b4044b1a858ea
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Apr 22 10:24:29 2023 +0200

    match.pd: Fix fneg/fadd optimization [PR109583]

    The following testcase ICEs on x86, foo function since my r14-22
    improvement, but bar already since r13-4122.  The problem is the same,
    in the if expression related_vector_mode is called and that starts with
      gcc_assert (VECTOR_MODE_P (vector_mode));
    but nothing in the fneg/fadd match.pd pattern actually checks if the
    VEC_PERM type has VECTOR_MODE_P (vec_mode).  In this case it has BLKmode
    and so it ICEs.

    The following patch makes sure we don't ICE on it.

    2023-04-22  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/109583
            * match.pd (fneg/fadd simplify): Don't call related_vector_mode
            if vec_mode is not VECTOR_MODE_P.

            * gcc.dg/pr109583.c: New test.

    (cherry picked from commit c58c0771b7a3dbd2a00cd4b6ca2301d74b6cd4e2)

  parent reply	other threads:[~2023-04-22  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  8:10 [Bug tree-optimization/109583] New: [14 " marxin at gcc dot gnu.org
2023-04-21  8:11 ` [Bug tree-optimization/109583] " marxin at gcc dot gnu.org
2023-04-21 10:14 ` rguenth at gcc dot gnu.org
2023-04-21 11:22 ` [Bug tree-optimization/109583] [13/14 " jakub at gcc dot gnu.org
2023-04-21 11:22 ` jakub at gcc dot gnu.org
2023-04-22  8:25 ` cvs-commit at gcc dot gnu.org
2023-04-22  8:33 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-24  9:12 ` marxin at gcc dot gnu.org
2023-04-24  9:15 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109583-4-Alv0yU5dP4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).