From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 884A33858282; Mon, 15 Apr 2024 18:53:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 884A33858282 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1713207219; bh=t+uhR+gr4kfJqvi4yHOlNUVBGq93nlI79t/Hh5rJMx4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=OeY9Ay+CCmXyy8m3ocB/44hu2NS0hC1x8irJfaBGTBEchGudw8RZWZDAQiNNkb7Hg oagx7+x0E+cwyPTmBxfC8kZ+Lv2lTL813f2laqMGjZICFPrL4NYEFBOGPJHNaJdIJj jEsiq+u4uiq79npwBX6WlCZ8VfBeiRA34zxQ8rZg= From: "hubicka at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/109596] [14 Regression] Lots of guality testcase fails on x86_64 after r14-162-gcda246f8b421ba Date: Mon, 15 Apr 2024 18:53:36 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: testsuite X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: testsuite-fail, wrong-debug X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109596 --- Comment #19 from Jan Hubicka --- I looked into the remaining exit/nonexit rename discussed here earlier befo= re the PR was closed. The following patch would restore the code to do the same calls as before my patch PR tree-optimization/109596 * tree-ssa-loop-ch.c (ch_base::copy_headers): Fix use of exit/nonex= it edges. diff --git a/gcc/tree-ssa-loop-ch.cc b/gcc/tree-ssa-loop-ch.cc index b7ef485c4cc..cd5f6bc3c2a 100644 --- a/gcc/tree-ssa-loop-ch.cc +++ b/gcc/tree-ssa-loop-ch.cc @@ -952,13 +952,13 @@ ch_base::copy_headers (function *fun) if (!single_pred_p (nonexit->dest)) { header =3D split_edge (nonexit); - exit =3D single_pred_edge (header); + nonexit =3D single_pred_edge (header); } edge entry =3D loop_preheader_edge (loop); propagate_threaded_block_debug_into (nonexit->dest, entry->dest); - if (!gimple_duplicate_seme_region (entry, exit, bbs, n_bbs, copied_b= bs, + if (!gimple_duplicate_seme_region (entry, nonexit, bbs, n_bbs, copied_bbs, true)) { delete candidate.static_exits; I however convinced myself this is an noop. both exit and nonexit sources h= ave same basic blocks.=20=20 propagate_threaded_block_debug_into walks predecessors of its first paramet= er and moves debug statements to the second parameter, so it does the same job, since the split BB is empty. gimple_duplicate_seme_region uses the parametr to update loop header but it does not do that correctly for loop header copying and we re-do it in tree-ssa-loop-ch. Still the code as it is now in trunk is very confusing, so perhaps we should update it?=