public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/109632] Inefficient codegen when complex numbers are emulated with structs Date: Tue, 02 May 2023 15:00:06 +0000 [thread overview] Message-ID: <bug-109632-4-aUd626Urj0@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109632-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109632 --- Comment #10 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> --- After prototyping this further, I no longer think that lowering at the gimple level is the best answer. (I should have listened to Richi.) Although it works, its major drawback is that it's one-sided: it allows the current function's PARM_DECLs and returns to be lowered to individual scalars, but it does nothing for calls to other functions. Being one-sided means (a) that lowering only solves half the problem and (b) that tail calls cannot be handled easily after lowering. One thing that does seem to work is to force the structure to have V2SF (and fix the inevitable ABI fallout). That could only be done conditionally, based on a target hook. But it seems to fix both test cases: the pass-by-reference one and the pass-by-value one.
next prev parent reply other threads:[~2023-05-02 15:00 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-26 13:03 [Bug target/109632] New: " tnfchris at gcc dot gnu.org 2023-04-26 14:14 ` [Bug target/109632] " rguenth at gcc dot gnu.org 2023-04-26 14:40 ` tnfchris at gcc dot gnu.org 2023-04-26 15:23 ` tnfchris at gcc dot gnu.org 2023-04-27 7:52 ` rsandifo at gcc dot gnu.org 2023-04-27 11:17 ` rsandifo at gcc dot gnu.org 2023-04-27 11:24 ` tnfchris at gcc dot gnu.org 2023-04-27 13:33 ` rsandifo at gcc dot gnu.org 2023-04-27 17:50 ` rsandifo at gcc dot gnu.org 2023-04-27 19:11 ` tnfchris at gcc dot gnu.org 2023-05-02 15:00 ` rsandifo at gcc dot gnu.org [this message] 2023-05-23 10:34 ` cvs-commit at gcc dot gnu.org 2023-05-23 19:16 ` rsandifo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109632-4-aUd626Urj0@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).