public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109642] False Positive -Wdangling-reference with std::span-like classes
Date: Fri, 01 Mar 2024 20:55:15 +0000	[thread overview]
Message-ID: <bug-109642-4-uEtJEC3lGR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109642-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109642

--- Comment #19 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:c7607c4cf18986025430ca8626abfe56bfe87106

commit r14-9263-gc7607c4cf18986025430ca8626abfe56bfe87106
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Jan 25 16:38:51 2024 -0500

    c++: implement [[gnu::no_dangling]] [PR110358]

    Since -Wdangling-reference has false positives that can't be
    prevented, we should offer an easy way to suppress the warning.
    Currently, that is only possible by using a #pragma, either around the
    enclosing class or around the call site.  But #pragma GCC diagnostic tend
    to be onerous.  A better solution would be to have an attribute.

    To that end, this patch adds a new attribute, [[gnu::no_dangling]].
    This attribute takes an optional bool argument to support cases like:

      template <typename T>
      struct [[gnu::no_dangling(std::is_reference_v<T>)]] S {
         // ...
      };

            PR c++/110358
            PR c++/109642

    gcc/cp/ChangeLog:

            * call.cc (no_dangling_p): New.
            (reference_like_class_p): Use it.
            (do_warn_dangling_reference): Use it.  Don't warn when the function
            or its enclosing class has attribute gnu::no_dangling.
            * tree.cc (cxx_gnu_attributes): Add gnu::no_dangling.
            (handle_no_dangling_attribute): New.

    gcc/ChangeLog:

            * doc/extend.texi: Document gnu::no_dangling.
            * doc/invoke.texi: Mention that gnu::no_dangling disables
            -Wdangling-reference.

    gcc/testsuite/ChangeLog:

            * g++.dg/ext/attr-no-dangling1.C: New test.
            * g++.dg/ext/attr-no-dangling2.C: New test.
            * g++.dg/ext/attr-no-dangling3.C: New test.
            * g++.dg/ext/attr-no-dangling4.C: New test.
            * g++.dg/ext/attr-no-dangling5.C: New test.
            * g++.dg/ext/attr-no-dangling6.C: New test.
            * g++.dg/ext/attr-no-dangling7.C: New test.
            * g++.dg/ext/attr-no-dangling8.C: New test.
            * g++.dg/ext/attr-no-dangling9.C: New test.

  parent reply	other threads:[~2024-03-01 20:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  6:36 [Bug c++/109642] New: " carlosgalvezp at gmail dot com
2023-04-27  7:03 ` [Bug c++/109642] " pinskia at gcc dot gnu.org
2023-04-27  7:09 ` carlosgalvezp at gmail dot com
2023-04-27 15:49 ` mpolacek at gcc dot gnu.org
2023-04-27 19:20 ` carlosgalvezp at gmail dot com
2023-04-28 13:00 ` mpolacek at gcc dot gnu.org
2023-04-28 14:08 ` carlosgalvezp at gmail dot com
2023-05-02 19:49 ` cvs-commit at gcc dot gnu.org
2023-06-21 18:43 ` pinskia at gcc dot gnu.org
2023-06-21 18:51 ` mpolacek at gcc dot gnu.org
2023-06-21 19:06 ` barry.revzin at gmail dot com
2024-01-17 12:16 ` miro.palmu at helsinki dot fi
2024-01-19 17:35 ` mpolacek at gcc dot gnu.org
2024-01-19 23:32 ` mpolacek at gcc dot gnu.org
2024-01-22 20:52 ` mpolacek at gcc dot gnu.org
2024-01-22 21:16 ` cvs-commit at gcc dot gnu.org
2024-01-30 18:32 ` mpolacek at gcc dot gnu.org
2024-01-30 18:38 ` lopresti at gmail dot com
2024-01-30 18:42 ` mpolacek at gcc dot gnu.org
2024-03-01 20:55 ` cvs-commit at gcc dot gnu.org [this message]
2024-05-01 17:18 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109642-4-uEtJEC3lGR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).