public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/109644] Missing GIMPLE IL verification
Date: Fri, 28 Apr 2023 09:49:21 +0000	[thread overview]
Message-ID: <bug-109644-4-dvHfntbajp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109644-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109644

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:6e6f86f22873aab7059e083fd0c9905bd58e5efa

commit r14-324-g6e6f86f22873aab7059e083fd0c9905bd58e5efa
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Apr 24 13:20:25 2023 +0200

    tree-optimization/109644 - missing IL checking

    We fail to verify the constraints under which we allow handled
    components to wrap registers.  The gcc.dg/pr70022.c testcase shows
    that we happily end up with

      _2 = VIEW_CONVERT_EXPR<int[4]>(v_1(D))

    as produced by SSA rewrite and update_address_taken.  But the intent
    was that we wrap registers with at most a single level of handled
    components and specifically only allow __real, __imag, BIT_FIELD_REF
    and VIEW_CONVERT_EXPR on them, but not ARRAY_REF or COMPONENT_REF.

    The following makes IL verification stricter which catches the
    problem.

            PR tree-optimization/109644
            * tree-cfg.cc (verify_types_in_gimple_reference): Check
            register constraints on the outermost VIEW_CONVERT_EXPR
            only.  Do not allow register or invariant bases on
            multi-level or possibly variable index handled components.

  parent reply	other threads:[~2023-04-28  9:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  8:41 [Bug middle-end/109644] New: " rguenth at gcc dot gnu.org
2023-04-27  8:43 ` [Bug middle-end/109644] " rguenth at gcc dot gnu.org
2023-04-27 10:31 ` rguenth at gcc dot gnu.org
2023-04-28  9:49 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-28  9:49 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109644-4-dvHfntbajp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).