public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109661] [13/14 Regression] ICE in aarch64_function_arg_alignment when building erlang
Date: Wed, 03 May 2023 16:44:16 +0000	[thread overview]
Message-ID: <bug-109661-4-0lvyfUaBEO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109661-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109661

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:3a4a39b391e63e5be04cb06ee4cd5400bef63dfc

commit r14-455-g3a4a39b391e63e5be04cb06ee4cd5400bef63dfc
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed May 3 17:43:48 2023 +0100

    aarch64: Rename abi_break parameters [PR109661]

    aarch64_function_arg_alignment has two related abi_break
    parameters: abi_break for a change in GCC 9, and abi_break_packed
    for a related follow-on change in GCC 13.  In a sense, abi_break_packed
    is a "subfix" of abi_break.

    PR109661 now requires a third ABI break that is independent
    of the other two.  Having abi_break for the GCC 9 break and
    abi_break_<something> for the GCC 13 and GCC 14 breaks might
    give the impression that they're all related, and that the GCC 14
    fix (like the GCC 13 fix) is a "subfix" of the GCC 9 one.
    It therefore seemed like a good idea to rename the existing
    variables first.

    It would be difficult to choose names that describe briefly and
    precisely what went wrong in each case.  The next best thing
    seemed to be to name them after the relevant GCC version.
    (Of course, this might break down in future if we need two
    independent fixes in the same version.  Let's hope not.)

    I wondered about putting all the variables in a structure,
    but one advantage of using independent variables is that it's
    harder to forget to update a caller.  Maybe a fourth parameter
    would be a tipping point.

    gcc/
            PR target/109661
            * config/aarch64/aarch64.cc (aarch64_function_arg_alignment):
Rename
            ABI break variables to abi_break_gcc_9 and abi_break_gcc_13.
            (aarch64_layout_arg, aarch64_function_arg_boundary): Likewise.
            (aarch64_gimplify_va_arg_expr): Likewise.

  parent reply	other threads:[~2023-05-03 16:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28  8:18 [Bug target/109661] New: " jakub at gcc dot gnu.org
2023-04-28  8:18 ` [Bug target/109661] " jakub at gcc dot gnu.org
2023-04-28  8:19 ` jakub at gcc dot gnu.org
2023-04-28  8:28 ` jakub at gcc dot gnu.org
2023-04-28  8:44 ` jakub at gcc dot gnu.org
2023-04-28  8:56 ` rsandifo at gcc dot gnu.org
2023-04-28  8:56 ` rsandifo at gcc dot gnu.org
2023-05-02 11:29 ` jakub at gcc dot gnu.org
2023-05-02 11:50 ` rsandifo at gcc dot gnu.org
2023-05-03 16:44 ` cvs-commit at gcc dot gnu.org [this message]
2023-05-03 16:44 ` cvs-commit at gcc dot gnu.org
2023-05-03 16:49 ` [Bug target/109661] [13 " rsandifo at gcc dot gnu.org
2023-05-09 12:18 ` sjames at gcc dot gnu.org
2023-05-11 11:36 ` cvs-commit at gcc dot gnu.org
2023-07-19 11:24 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109661-4-0lvyfUaBEO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).