public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "john.harper at vuw dot ac.nz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/109662] bad namelist input but gfortran accepted it
Date: Sun, 07 May 2023 21:46:33 +0000	[thread overview]
Message-ID: <bug-109662-4-JiLRpseh58@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109662-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109662

--- Comment #14 from john.harper at vuw dot ac.nz ---
Rejecting a semicolon after the namelist name even if the decimal edit 
mode is COMMA makes sense because COMMA was first allowed in f2003, 
provided that semicolons in namelist were a pre-f2003 legacy possibility.

John H

On Sun, 7 May 2023, jvdelisle at gcc dot gnu.org wrote:

> Date: Sun, 7 May 2023 18:14:23 +0000
> From: jvdelisle at gcc dot gnu.org <gcc-bugzilla@gcc.gnu.org>
> To: John Harper <john.harper@vuw.ac.nz>
> Subject: [Bug libfortran/109662] bad namelist input but gfortran accepted it
> Resent-Date: Mon, 8 May 2023 06:14:37 +1200 (NZST)
> Resent-From: <john.harper@vuw.ac.nz>
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109662
>
> --- Comment #12 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
> A additional adjustment to reject the semi-colon always.
>
> diff --git a/libgfortran/io/list_read.c b/libgfortran/io/list_read.c
> index 78bfd9e8787..db3330060ce 100644
> --- a/libgfortran/io/list_read.c
> +++ b/libgfortran/io/list_read.c
> @@ -3598,9 +3598,9 @@ find_nml_name:
>
>   /* A trailing space is required, we allow a comma with std=gnu.  */
>   c = next_char (dtp);
> -  if (c == ',' && !(compile_options.allow_std & GFC_STD_GNU))
> +  if ((c == ',' && !(compile_options.allow_std & GFC_STD_GNU)) || c == ';')
>     generate_error (&dtp->common, LIBERROR_READ_VALUE,
> -                   "Comma after namelist name not allowed");
> +                   "Non blank after namelist name not allowed");
>
>   if (!is_separator(c) && c != '!')
>     {
>
> -- 
> You are receiving this mail because:
> You reported the bug.
>


-- John Harper, School of Mathematics and Statistics
Victoria Univ. of Wellington, PO Box 600, Wellington 6140, New Zealand.
e-mail john.harper@vuw.ac.nz phone +64(0) 4 463 5276

  parent reply	other threads:[~2023-05-07 21:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28  8:20 [Bug fortran/109662] New: " john.harper at vuw dot ac.nz
2023-04-28 21:20 ` [Bug libfortran/109662] " anlauf at gcc dot gnu.org
2023-04-30 22:40 ` kargl at gcc dot gnu.org
2023-05-01  0:37 ` jvdelisle at gcc dot gnu.org
2023-05-01  3:05 ` jvdelisle at gcc dot gnu.org
2023-05-04  3:05 ` jvdelisle at gcc dot gnu.org
2023-05-04  4:59 ` john.harper at vuw dot ac.nz
2023-05-04  6:00 ` john.harper at vuw dot ac.nz
2023-05-05  2:44 ` jvdelisle at gcc dot gnu.org
2023-05-06 14:23 ` cvs-commit at gcc dot gnu.org
2023-05-06 14:45 ` jvdelisle at gcc dot gnu.org
2023-05-07  2:15 ` john.harper at vuw dot ac.nz
2023-05-07 18:14 ` jvdelisle at gcc dot gnu.org
2023-05-07 18:35 ` jvdelisle at gcc dot gnu.org
2023-05-07 21:46 ` john.harper at vuw dot ac.nz [this message]
2023-05-07 21:55 ` john.harper at vuw dot ac.nz
2023-05-07 22:10 ` john.harper at vuw dot ac.nz
2023-05-08  2:03 ` cvs-commit at gcc dot gnu.org
2023-05-09  0:41 ` jvdelisle at gcc dot gnu.org
2023-05-09  1:15 ` jvdelisle at gcc dot gnu.org
2023-05-12 20:41 ` cvs-commit at gcc dot gnu.org
2023-05-12 20:41 ` cvs-commit at gcc dot gnu.org
2023-08-25  1:03 ` jvdelisle at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109662-4-JiLRpseh58@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).