From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 24CCE3857730; Wed, 10 May 2023 22:25:03 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24CCE3857730
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683757503;
	bh=Kq+zmyUZS+c55uO9vQh1ASXGJDPbFkqH1uVsBONCQlY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=gHBSfNBlgL+HEhamns+44ICtxNdCYwfQg8vuQwd6RXmvcVgOwu4div7p4UEKCV2ot
	 VKJdKb5ZAM777v10tj0x4GLdhV34Rg5ZK09/Nlf2pfsKs5naUZRp9Eo024Js54A0fU
	 kvsFU0vBujjzEU3oVe1HTwHWyi6kqzLMA3qGO7lU=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109680] [13/14 Regression] is_convertible<int() const,
 int(*)()> incorrectly true
Date: Wed, 10 May 2023 22:25:02 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.1.0
X-Bugzilla-Keywords: patch, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109680-4-6tFsHlrtDy@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109680-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109680-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109680

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:4c2ffb02fd4104d77c5d907662f04434dc4c3fe8

commit r14-669-g4c2ffb02fd4104d77c5d907662f04434dc4c3fe8
Author: Marek Polacek <polacek@redhat.com>
Date:   Tue May 2 17:36:00 2023 -0400

    c++: wrong std::is_convertible with cv-qual fn [PR109680]

    This PR points out that std::is_convertible has given the wrong answer
    in

      static_assert (!std::is_convertible_v <int () const, int (*) ()>, "");

    since r13-2822 implemented __is_{,nothrow_}convertible.

    std::is_convertible uses the imaginary

      To test() { return std::declval<From>(); }

    to do its job.  Here, From is 'int () const'.  std::declval is defined =
as:

      template<class T>
      typename std::add_rvalue_reference<T>::type declval() noexcept;

    std::add_rvalue_reference is defined as "If T is a function type that
    has no cv- or ref- qualifier or an object type, provides a member typed=
ef
    type which is T&&, otherwise type is T."

    In our case, T is cv-qualified, so the result is T, so we end up with

      int () const declval() noexcept;

    which is invalid.  In other words, this is pretty much like:

      using T =3D int () const;
      T fn1(); // bad, fn returning a fn
      T& fn2(); // bad, cannot declare reference to qualified function type
      T* fn3(); // bad, cannot declare pointer to qualified function type

      using U =3D int ();
      U fn4(); // bad, fn returning a fn
      U& fn5(); // OK
      U* fn6(); // OK

    I think is_convertible_helper needs to simulate std::declval better.
    To that end, I'm introducing build_trait_object, to be used where
    a declval is needed.

            PR c++/109680

    gcc/cp/ChangeLog:

            * method.cc (build_trait_object): New.
            (assignable_expr): Use it.
            (ref_xes_from_temporary): Likewise.
            (is_convertible_helper): Likewise.  Check FUNC_OR_METHOD_TYPE_P.

    gcc/testsuite/ChangeLog:

            * g++.dg/ext/is_convertible6.C: New test.=