public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/109680] [13/14 Regression] is_convertible<int() const, int(*)()> incorrectly true Date: Mon, 01 May 2023 23:13:14 +0000 [thread overview] Message-ID: <bug-109680-4-vWODUkGfQL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109680-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109680 --- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> --- (In reply to Jakub Jelinek from comment #4) > template <typename T, typename U = T&&> > U __declval (int); > template <typename T> > T __declval (long); > template <typename T> > auto declval () noexcept -> decltype (__declval <T> (0)); > using To = int () const; > using From = int (*) (); > To foo () { return declval <From> (); } > From bar () { return declval <To> (); } > static_assert (!__is_convertible (To, From), ""); > static_assert (!__is_convertible (From, To), ""); > should show that both assertions should succeed. Thanks. > Dunno if in this case the > reason why it isn't convertible is simply the fact that functions can't be > declared to return function/method/array types or some other reason as well. Yeah, I'm also not sure, so I think this should fix it: --- a/gcc/cp/method.cc +++ b/gcc/cp/method.cc @@ -2245,6 +2245,8 @@ is_convertible_helper (tree from, tree to) { if (VOID_TYPE_P (from) && VOID_TYPE_P (to)) return integer_one_node; + if (FUNC_OR_METHOD_TYPE_P (from) || FUNC_OR_METHOD_TYPE_P (to)) + return error_mark_node; cp_unevaluated u; tree expr = build_stub_object (from); deferring_access_check_sentinel acs (dk_no_deferred); Since static_assert (!__is_convertible (int[3], int[3]), ""); already passes, arrays are handled correctly I think.
next prev parent reply other threads:[~2023-05-01 23:13 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-29 17:13 [Bug c++/109680] New: Regression where `int() const` is considered convertible to `int(*)()` dpsicilia at gmail dot com 2023-04-29 17:28 ` [Bug c++/109680] " pinskia at gcc dot gnu.org 2023-04-29 17:42 ` [Bug c++/109680] [13/14 Regression] is_convertible<int() const, int(*)()> incorrectly true pinskia at gcc dot gnu.org 2023-05-01 9:03 ` jakub at gcc dot gnu.org 2023-05-01 16:09 ` mpolacek at gcc dot gnu.org 2023-05-01 16:32 ` jakub at gcc dot gnu.org 2023-05-01 23:13 ` mpolacek at gcc dot gnu.org [this message] 2023-05-02 7:36 ` jakub at gcc dot gnu.org 2023-05-02 19:22 ` mpolacek at gcc dot gnu.org 2023-05-03 12:58 ` mpolacek at gcc dot gnu.org 2023-05-10 22:25 ` cvs-commit at gcc dot gnu.org 2023-05-10 22:25 ` [Bug c++/109680] [13 " mpolacek at gcc dot gnu.org 2023-07-03 12:08 ` dpsicilia at gmail dot com 2023-07-03 12:36 ` redi at gcc dot gnu.org 2023-07-27 9:25 ` rguenth at gcc dot gnu.org 2023-08-04 18:08 ` pinskia at gcc dot gnu.org 2024-05-21 9:14 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109680-4-vWODUkGfQL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).