From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id AF7413858C62; Wed,  3 May 2023 08:02:03 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF7413858C62
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683100923;
	bh=1TK/kWkbSelSarDsyK2QXGTKzIV7K8vZUhB9Ln4Oozw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ZBRgXZC01vl+9V0hrkaD8ejxLTzCzBVMA17fCrNBtY8ZtyPBjOcy0Eq7kIiBtFbJf
	 P6keMXpc5eVncPWZ/qVodCA7MtKBkLZJyzA9+zmOlQo2EsWsXyfjNLhOiSHdGBJ+Yk
	 hRzvxxNHKq4xNVFnkHxHZXK0fm3lqdroCNKvzCag=
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109695] [14 Regression] crash in
 gimple_ranger::range_of_expr
Date: Wed, 03 May 2023 08:02:02 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mikael at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: aldyh at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-109695-4-WsjeId2BCH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109695-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109695-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109695

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #8 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #7)
>=20
> diff --git a/gcc/gimple-range.cc b/gcc/gimple-range.cc
> index 49e9d6b4de6..74afaaf2989 100644
> --- a/gcc/gimple-range.cc
> +++ b/gcc/gimple-range.cc
> @@ -394,7 +394,9 @@ gimple_ranger::prefill_stmt_dependencies (tree ssa)
>  	      Value_Range tmp (TREE_TYPE (name));
>  	      m_cache.get_global_range (tmp, name);
>  	      r.intersect (tmp);
> -	      m_cache.set_global_range (name, r);
> +	      // Only update the global range if it changes.
> +	      if (r !=3D tmp)
> +		m_cache.set_global_range (name, r);
>  	    }
>  	  continue;
>  	}

Maybe the result of intersect could be used to check for changes?

if (tmp.intersect(r))
  ...=