From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 262F63858C33; Wed, 3 May 2023 13:14:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 262F63858C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683119667; bh=PVQM9XO4XZr9UJnOUyWSFJlNDq2XC+sLWWg3oja8Iq0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=u7YZ1lFwo1GeYJ+u5NQSDt4WozSGI+qixR5Xzj+AjW/WFf0d5eFPPFJdsH9d4gJ0v 2zzXq3WrkMdRKiV5+EO0W7+8rU73FfVZ8ZRC9D3v0HiVukdT1o4+Zv0XTWSligqPzK Xt7JfJZeR02S0AEgtJ34PL8WVEjZ4t+L+KAglcPU= From: "tnfchris at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: =?UTF-8?B?W0J1ZyBpcGEvMTA5NzExXSBbMTQgcmVncmVzc2lvbl0gSUNFICh0?= =?UTF-8?B?cmVlIGNoZWNrOiBleHBlY3RlZCBjbGFzcyDigJh0eXBl4oCZLCBoYXZlIA==?= =?UTF-8?B?4oCYZXhjZXB0aW9uYWzigJkgKGVycm9yX21hcmspIGluIHZlcmlmeV9yYW5n?= =?UTF-8?B?ZSwgYXQgdmFsdWUtcmFuZ2UuY2M6MTA2MCkgd2hlbiBidWlsZGluZyBmZm1w?= =?UTF-8?B?ZWctNC40LjQgc2luY2UgcjE0LTM3Ny1nYzkyYjhiZTliNTJiN2U=?= Date: Wed, 03 May 2023 13:14:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-checking X-Bugzilla-Severity: normal X-Bugzilla-Who: tnfchris at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109711 --- Comment #5 from Tamar Christina --- (In reply to Martin Li=C5=A1ka from comment #3) > Hm, on x86_64-linux-gnu, it started with r13-6616-g2246d576f922ba. $ cat prtest2.c void lspf2lpc(); int interpolate_lpc_q_0; void interpolate_lpc(int subframe_num) { float weight; if (interpolate_lpc_q_0) weight =3D subframe_num; else weight =3D 1.0; if (weight !=3D 1.0) lspf2lpc(); } void qcelp_decode_frame() { int i; for (;; i++) interpolate_lpc(i); } $ ./install/bin/gcc --version gcc (GCC) 13.0.1 20230312 (experimental) $ git log -1 commit 2246d576f922bae3629da0fe1dbfcc6ff06769ad (HEAD) Author: Tamar Christina Date: Sun Mar 12 18:39:33 2023 +0000 middle-end: Revert can_special_div_by_const changes [PR108583] This reverts the changes for the CAN_SPECIAL_DIV_BY_CONST hook. gcc/ChangeLog: PR target/108583 * doc/tm.texi (TARGET_VECTORIZE_CAN_SPECIAL_DIV_BY_CONST): Remo= ve. * doc/tm.texi.in: Likewise. * explow.cc (round_push, align_dynamic_address): Revert previous patch. * expmed.cc (expand_divmod): Likewise. * expmed.h (expand_divmod): Likewise. * expr.cc (force_operand, expand_expr_divmod): Likewise. * optabs.cc (expand_doubleword_mod, expand_doubleword_divmod): Likewise. * target.def (can_special_div_by_const): Remove. * target.h: Remove tree-core.h include * targhooks.cc (default_can_special_div_by_const): Remove. * targhooks.h (default_can_special_div_by_const): Remove. * tree-vect-generic.cc (expand_vector_operation): Remove hook. * tree-vect-patterns.cc (vect_recog_divmod_pattern): Remove hoo= k. * tree-vect-stmts.cc (vectorizable_operation): Remove hook. $ ./install/bin/gcc -O2 -S -o - prtest2.c .file "prtest2.c" .text .p2align 4 .globl interpolate_lpc .type interpolate_lpc, @function interpolate_lpc: .LFB0: .cfi_startproc movl interpolate_lpc_q_0(%rip), %eax testl %eax, %eax je .L1 pxor %xmm0, %xmm0 cvtsi2ssl %edi, %xmm0 ucomiss .LC0(%rip), %xmm0 jp .L4 jne .L4 .L1: ret .p2align 4,,10 .p2align 3 ... Also that commit doesn't build because I forgot to cp tm.texi to the source directory after the revert. So I think the bisect probably didn't find it in that range. https://godbolt.org/z/r44xGzarY indicates GCC 13.1 is fine. So I don't thi= nk this one is mine.=