public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/109712] Segmentation fault in linear_search_fdes
Date: Mon, 05 Jun 2023 20:47:31 +0000	[thread overview]
Message-ID: <bug-109712-4-wugra11g1x@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109712-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109712

--- Comment #23 from Florian Weimer <fw at gcc dot gnu.org> ---
(In reply to Thomas Neumann from comment #21)
> It must be something more complex. value is small here (more precisely: 1888
> in the crashes later), which is not a valid pointer address. We probably
> have to add this to some base pointer? But it is not obvious to me to which
> one.

read_encoded_value_with_base has this:

          result += ((encoding & 0x70) == DW_EH_PE_pcrel
                     ? (_Unwind_Internal_Ptr) u : base);

u is the original read pointer as far as I can see. So it looks like it should
look like this:

diff --git a/libgcc/unwind-dw2-fde-dip.c b/libgcc/unwind-dw2-fde-dip.c
index 6223f5f18a2..5a6352227cc 100644
--- a/libgcc/unwind-dw2-fde-dip.c
+++ b/libgcc/unwind-dw2-fde-dip.c
@@ -403,8 +403,8 @@ find_fde_tail (_Unwind_Ptr pc,
         BFD ld generates.  */
       signed value __attribute__ ((mode (SI)));
       memcpy (&value, p, sizeof (value));
+      eh_frame = p + value
       p += sizeof (value);
-      dbase = value;           /* No adjustment because pcrel has base 0.  */
     }
   else
     p = read_encoded_value_with_base (hdr->eh_frame_ptr_enc,

  parent reply	other threads:[~2023-06-05 20:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 11:58 [Bug c++/109712] New: " carlosgalvezp at gmail dot com
2023-05-03 13:13 ` [Bug c++/109712] " rguenth at gcc dot gnu.org
2023-05-03 18:36 ` [Bug libgcc/109712] " pinskia at gcc dot gnu.org
2023-05-03 18:42 ` pinskia at gcc dot gnu.org
2023-05-04  7:38 ` carlosgalvezp at gmail dot com
2023-05-04  7:46 ` carlosgalvezp at gmail dot com
2023-05-13  8:23 ` carlosgalvezp at gmail dot com
2023-05-15  6:06 ` rguenth at gcc dot gnu.org
2023-05-15 14:36 ` carlosgalvezp at gmail dot com
2023-05-17  7:15 ` rguenth at gcc dot gnu.org
2023-06-03 20:39 ` carlosgalvezp at gmail dot com
2023-06-03 20:45 ` pinskia at gcc dot gnu.org
2023-06-04  6:20 ` carlosgalvezp at gmail dot com
2023-06-05  7:23 ` rguenth at gcc dot gnu.org
2023-06-05 10:44 ` tneumann at users dot sourceforge.net
2023-06-05 13:52 ` carlosgalvezp at gmail dot com
2023-06-05 14:53 ` tneumann at users dot sourceforge.net
2023-06-05 14:59 ` tneumann at users dot sourceforge.net
2023-06-05 15:17 ` carlosgalvezp at gmail dot com
2023-06-05 15:24 ` tneumann at users dot sourceforge.net
2023-06-05 15:34 ` fw at gcc dot gnu.org
2023-06-05 16:27 ` tneumann at users dot sourceforge.net
2023-06-05 20:34 ` carlosgalvezp at gmail dot com
2023-06-05 20:47 ` fw at gcc dot gnu.org [this message]
2023-06-05 20:48 ` fw at gcc dot gnu.org
2023-06-05 20:52 ` carlosgalvezp at gmail dot com
2023-06-05 20:59 ` tneumann at users dot sourceforge.net
2023-06-06  7:45 ` [Bug libgcc/109712] [13/14 Regression] " rguenth at gcc dot gnu.org
2023-06-06  9:52 ` fw at gcc dot gnu.org
2023-06-07 12:20 ` carlosgalvezp at gmail dot com
2023-06-07 12:23 ` carlosgalvezp at gmail dot com
2023-06-07 15:55 ` cvs-commit at gcc dot gnu.org
2023-06-07 15:56 ` fw at gcc dot gnu.org
2023-07-09  6:54 ` [Bug libgcc/109712] [13 " pinskia at gcc dot gnu.org
2023-07-10 10:28 ` fw at gcc dot gnu.org
2023-07-18 13:55 ` rguenth at gcc dot gnu.org
2023-07-18 14:28 ` fw at gcc dot gnu.org
2023-07-18 15:02 ` cvs-commit at gcc dot gnu.org
2023-07-18 15:11 ` fw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109712-4-wugra11g1x@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).