public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109722] New: ABSU<a> == 0 is not optimized to just a == 0 Date: Thu, 04 May 2023 00:40:58 +0000 [thread overview] Message-ID: <bug-109722-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109722 Bug ID: 109722 Summary: ABSU<a> == 0 is not optimized to just a == 0 Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: enhancement Priority: P3 Component: tree-optimization Assignee: pinskia at gcc dot gnu.org Reporter: pinskia at gcc dot gnu.org Target Milestone: --- Take: ``` int f(signed char a) { int t = a; if (t < 0) t = -t; a = t; return a == 0; } ``` Right now this gets optimized to just: ``` _9 = ABSU_EXPR <a_3(D)>; _1 = _9 == 0; _7 = (int) _1; ``` If we change `signed char` to `unsigned char`, we get: _1 = a_2(D) == 0; _3 = (int) _1; As we had expected for the original case too. The fix is to change in match.pd: /* Convert ABS_EXPR<x> == 0 or ABS_EXPR<x> != 0 to x == 0 or x != 0. */ (for op (eq ne) (simplify (op (abs @0) zerop@1) (op @0 @1))) to: /* Convert ABS[U]_EXPR<x> == 0 or ABS[U]_EXPR<x> != 0 to x == 0 or x != 0. */ (for op (abs absu) (for eqne (eq ne) (simplify (eqne (op @0) zerop@1) (eqne @0 @1)))
next reply other threads:[~2023-05-04 0:40 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-04 0:40 pinskia at gcc dot gnu.org [this message] 2023-05-04 0:41 ` [Bug tree-optimization/109722] " pinskia at gcc dot gnu.org 2023-05-04 0:42 ` pinskia at gcc dot gnu.org 2023-05-04 3:35 ` pinskia at gcc dot gnu.org 2023-05-04 23:41 ` pinskia at gcc dot gnu.org 2023-05-05 5:23 ` cvs-commit at gcc dot gnu.org 2023-05-05 5:24 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109722-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).