From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D16923858C52; Thu,  4 May 2023 18:17:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D16923858C52
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683224243;
	bh=Z0a60cbaWsmzkjt+rEYxI2H4SPtdmA1WryA5Equeg9M=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=dew/BhwQ+s57vgx3j3kQhEx9n6533ywPjHAT2KJoe7d/EpSWeAeeqI6ga0EkVPxdp
	 ToW9Iq7JN8UWev9Vmw964srXzueoWwv6Zb3wNT5/NBhp6ut29zskG/BYpST9ZAcV7p
	 OWKu6oykZyKv8dotxQspRGicjnSl+ubqM2gerBNM=
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/109741] alignas(64) in
 libstdc++-v3/src/c++11/shared_ptr.cc
Date: Thu, 04 May 2023 18:17:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 13.1.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109741-4-5cYk3IvxRf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109741-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109741-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109741

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Janez Zemva from comment #0)
> This line:
>=20
> struct alignas(64) M : __gnu_cxx::__mutex { };
>=20
> has been an eyesore for me for a number of years. I propose to change it

That belongs on the mailing list, not in bugzilla.

> into:
>=20
> struct alignas(std::max_align_t) M : __gnu_cxx::__mutex { };

That would be completely wrong though.


(In reply to Janez Zemva from comment #1)
> alternatively, the line could be changed into:
>=20
> struct alignas(void*) M : __gnu_cxx::__mutex { };
>=20
> since this was probably meant with the magic number 64.

That would be even more wrong. Please just read the comment instead of maki=
ng
silly assumptions about what we meant.


(In reply to Janez Zemva from comment #5)
> This line has been patched out by djgpp builds for a long time now.

Then say that, instead of suggesting incorrect changes.=