From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B555F3854172; Fri, 12 May 2023 15:08:12 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B555F3854172
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683904092;
	bh=jtda1I10VzJnYsPGCVRlrZoLG+sO0xZtd0tP1Fri/lA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=i98w4lqZiqLNJZcKp5wEM8TeCp6SapQBwfVVsIkZBzXL1fETfBA7PPLjFkW+lsmEp
	 913A0WfNrp6UrozSy4WbgccmB8u+B9rs0Oxkz/uMmleqIfFx6apbiVxn1B2KdH35Ix
	 nPpbQuVaepmQN9lt4zbhScni2YeyrfwgSQGwJ8tQ=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109745] [13 Regression] Incorrect code generated with -O1
 when having a constexpr object modifying a mutable member
Date: Fri, 12 May 2023 15:08:12 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.1.0
X-Bugzilla-Keywords: accepts-invalid, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109745-4-kgp6b0BP9E@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109745-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109745-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109745

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:7f962e7003a51cc752ed79cbc7fe55ca66981c7a

commit r13-7326-g7f962e7003a51cc752ed79cbc7fe55ca66981c7a
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu May 11 16:31:33 2023 -0400

    c++: 'mutable' subobject of constexpr variable [PR109745]

    r13-2701-g7107ea6fb933f1 made us correctly accept during constexpr
    evaluation 'mutable' member accesses of objects constructed during
    that evaluation, while continuing to reject such accesses for constexpr
    objects constructed outside of that evaluation, by considering the
    CONSTRUCTOR_MUTABLE_POISON flag during cxx_eval_component_reference.

    However, this flag is set only for the outermost CONSTRUCTOR of a
    constexpr variable initializer, so if we're accessing a 'mutable' member
    of a nested CONSTRUCTOR, the flag won't be set and we won't reject the
    access.  This can lead to us accepting invalid code, as in the first
    testcase, or even wrong code generation due to our speculative constexpr
    evaluation, as in the second and third testcase.

    This patch fixes this by setting CONSTRUCTOR_MUTABLE_POISON recursively
    rather than only on the outermost CONSTRUCTOR.

            PR c++/109745

    gcc/cp/ChangeLog:

            * typeck2.cc (poison_mutable_constructors): Define.
            (store_init_value): Use it instead of setting
            CONSTRUCTOR_MUTABLE_POISON directly.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/constexpr-mutable4.C: New test.
            * g++.dg/cpp0x/constexpr-mutable5.C: New test.
            * g++.dg/cpp1y/constexpr-mutable2.C: New test.

    (cherry picked from commit 02777f20be4f40160f1b4ed34fa59ba75245b5b7)=