public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/109752] [13/14 regression] ICE in check_complete_insertion, at hash-table.h:578 since r13-4937 Date: Tue, 09 May 2023 19:08:12 +0000 [thread overview] Message-ID: <bug-109752-4-y1rYkGvF0f@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109752-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109752 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:bbb6cf926f1732559b3a8aaf2796d34e8651c066 commit r14-640-gbbb6cf926f1732559b3a8aaf2796d34e8651c066 Author: Patrick Palka <ppalka@redhat.com> Date: Tue May 9 15:07:00 2023 -0400 c++: error-recovery ICE with unstable satisfaction [PR109752] After diagnosing and recovering from unstable satisfaction, it's possible to evaluate an atom for the first time noisily rather than quietly. The satisfaction cache tries to handle this situation gracefully, but apparently not gracefully enough: we inserted an empty slot into the cache, and left it empty, which later makes hash_table::check_complete_insertion unhappy. This patch fixes this by removing the empty slot in this case. PR c++/109752 gcc/cp/ChangeLog: * constraint.cc (satisfaction_cache::satisfaction_cache): In the unexpected case of evaluating an atom for the first time noisily, remove the cache slot that we inserted. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/concepts-pr109752.C: New test.
next prev parent reply other threads:[~2023-05-09 19:08 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-05 17:50 [Bug c++/109752] New: [ICE] in check_complete_insertion, at hash-table.h:578 ldalessandro at gmail dot com 2023-05-05 17:52 ` [Bug c++/109752] " pinskia at gcc dot gnu.org 2023-05-05 17:52 ` pinskia at gcc dot gnu.org 2023-05-05 18:00 ` ldalessandro at gmail dot com 2023-05-05 18:08 ` ldalessandro at gmail dot com 2023-05-05 19:35 ` pinskia at gcc dot gnu.org 2023-05-06 22:08 ` redi at gcc dot gnu.org 2023-05-06 22:10 ` redi at gcc dot gnu.org 2023-05-08 14:40 ` [Bug c++/109752] [13/14 regression] ICE in check_complete_insertion, at hash-table.h:578 since r13-4937 ppalka at gcc dot gnu.org 2023-05-09 19:08 ` cvs-commit at gcc dot gnu.org [this message] 2023-05-09 19:10 ` [Bug c++/109752] [13 " ppalka at gcc dot gnu.org 2023-05-12 12:38 ` cvs-commit at gcc dot gnu.org 2023-05-12 12:47 ` ppalka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109752-4-y1rYkGvF0f@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).