public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/109767] [OpenMP][5.2] Missing loop-variable privatization inside 'teams' Date: Mon, 08 May 2023 15:20:22 +0000 [thread overview] Message-ID: <bug-109767-4-gINZWrntgP@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109767-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109767 --- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> --- (In reply to Jakub Jelinek from comment #1) > Note, it is a Fortran only rule. > So, shared(j) on teams-loop-var.c is fully correct. Ups. True. > And, looking at Fortran, I already see it being private (by > fortran/openmp.cc (gfc_resolve_do_iterator)). > Thus, I don't see anything that needs to be done here. The problem is that for: !$omp teams !$omp loop the code GCC generates is: #pragma omp teams private(j) shared(i) #pragma omp distribute bind(teams) order(concurrent) private(i.2) lastprivate(i) #pragma omp parallel shared(j) lastprivate(i) #pragma omp for bind(teams) order(concurrent) private(i.1) #pragma omp simd lastprivate(i) bind(teams) order(concurrent) and there is a 'shared(j)' for parallel and no later 'private(j)' on either 'for' nor 'simd'. Thus, it is shared. - Which breaks the code. The problem is that PRIVATE happens early during parsing (→ search for gfc_resolve_do_iterator in openmp.cc) – but PARALLEL is only added in the middle end (→ gimplify_omp_loop).
next prev parent reply other threads:[~2023-05-08 15:20 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-08 9:10 [Bug middle-end/109767] New: " burnus at gcc dot gnu.org 2023-05-08 14:27 ` [Bug middle-end/109767] " jakub at gcc dot gnu.org 2023-05-08 14:41 ` jakub at gcc dot gnu.org 2023-05-08 15:20 ` burnus at gcc dot gnu.org [this message] 2023-05-08 15:29 ` jakub at gcc dot gnu.org 2023-05-08 15:51 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109767-4-gINZWrntgP@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).