From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 40297385AF8A; Fri, 28 Jul 2023 18:28:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40297385AF8A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1690568889;
	bh=QJ9M1HDAeAkdOubzGZZOTa3lEmmmxF75nSKrHEteTXQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=lJS3I4fjTrIYzkJE4l8ywMgNQrJ8XXysZDEKMTiOBQEia8QtcAtYMwXLvgIqfmPqA
	 BUVLUf5A8ykvmkzCxAMQrfkGT2S+ZcUlVNgpAxUFE/40StBGdtIe4rqTs7WOPeEMQW
	 hpvR6BMJNOTUZBk510FPzj2LRjV5hhqrG61Nr0og=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/109810] String literal exceeding array causes ICE
Date: Fri, 28 Jul 2023 18:28:08 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109810-4-61p4pgTSFz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109810-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109810-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109810

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Gaius Mulley
<gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:52405b14b7e6a8d13ac53525a341ebfd27ef67cc

commit r13-7633-g52405b14b7e6a8d13ac53525a341ebfd27ef67cc
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Fri Jul 28 19:27:18 2023 +0100

    PR modula2/109810 ICE fix when an array is assigned by a larger string

    This patch fixes an ICE when an array variable is assigned with
    a string which exceeds the array size.  It improves the accuracy
    of the virtual token used to indicate the error message.

    gcc/m2/ChangeLog:

            PR modula2/109810
            * gm2-compiler/M2ALU.mod (ConvertConstToType): Use
            PrepareCopyString in place of DoCopyString.
            * gm2-compiler/M2GenGCC.def (DoCopyString): Rename to ...
            (PrepareCopyString): ... this.
            * gm2-compiler/M2GenGCC.mod (CodeStatement): Call CodeReturnVal=
ue
            with a single parameter.  Call CodeXIndr with a single paramete=
r.
            (CodeReturnValue): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            (DoCopyString): Reimplement and rename to ...
            (PrepareCopyString): ... this.
            (CodeXIndr): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            (CodeBecomes): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            * gm2-compiler/M2Quads.def (BuildReturn): Rename parameter to
            tokreturn.
            * gm2-compiler/M2Quads.mod (BuildReturn): Rename parameter to
            tokreturn.  Rename tokno to tokcombined.

    gcc/testsuite/ChangeLog:

            PR modula2/109810
            * gm2/pim/fail/highice.mod: New test.

    (cherry picked from commit c787f593e62869ae0b230949b4791f4f3a26e50e)

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>=