From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 7DE07385770F; Thu, 11 May 2023 23:19:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DE07385770F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683847196;
	bh=kubQUI/ho3UpBqpbV9SYnAqagg9ogSMQmENpPOR3lAw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ZwtJCGrNx9CL8ZvNJx/CUcZw4VllMbvMWv0XF9T653I93UqdiZBK32o9Sb/xw2/8z
	 9u745qZ2TaqyA1NC32Qy4P5IDNFat7sR7RliKgouIrhE3BhJy1OjnGYp5F4k1R5av6
	 glqHesrdfnZDrFr6ucalSN42yDggUTBODTGfzjlU=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/109810] String literal exceeding array causes ICE
Date: Thu, 11 May 2023 23:19:56 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: modula2
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: gaius at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109810-4-uMkJysVG4l@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109810-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109810-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109810

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:c787f593e62869ae0b230949b4791f4f3a26e50e

commit r14-743-gc787f593e62869ae0b230949b4791f4f3a26e50e
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Fri May 12 00:15:28 2023 +0100

    PR modula2/109810 ICE fix when an array is assigned by a larger string

    This patch fixes an ICE when an array variable is assigned with
    a string which exceeds the array size.  It improves the accuracy
    of the virtual token used to indicate the error message.

    gcc/m2/ChangeLog:

            PR modula2/109810
            * gm2-compiler/M2ALU.mod (ConvertConstToType): Use
            PrepareCopyString in place of DoCopyString.
            * gm2-compiler/M2GenGCC.def (DoCopyString): Rename to ...
            (PrepareCopyString): ... this.
            * gm2-compiler/M2GenGCC.mod (CodeStatement): Call CodeReturnVal=
ue
            with a single parameter.  Call CodeXIndr with a single paramete=
r.
            (CodeReturnValue): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            (DoCopyString): Reimplement and rename to ...
            (PrepareCopyString): ... this.
            (CodeXIndr): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            (CodeBecomes): Remove parameters and replace with a single
            quadno.  Reimplement using PrepareCopyString.  Issue error
            if the string exceeds designator space.
            * gm2-compiler/M2Quads.def (BuildReturn): Rename parameter to
            tokreturn.
            * gm2-compiler/M2Quads.mod (BuildReturn): Rename parameter to
            tokreturn.  Rename tokno to tokcombined.

    gcc/testsuite/ChangeLog:

            PR modula2/109810
            * gm2/pim/fail/highice.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>=