public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/109819] New: [OpenMP][OpenACC] -fno-lto effectively disables offloading
Date: Thu, 11 May 2023 21:17:36 +0000	[thread overview]
Message-ID: <bug-109819-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109819

            Bug ID: 109819
           Summary: [OpenMP][OpenACC] -fno-lto effectively disables
                    offloading
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: openacc, openmp
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---

In terms of LTO, the idea is for the link time:
If there is -flto → we know that we should do LTO and, hence, need to check
whether there is some. Without -flto, it might be that there is LTO and with
slim LTO, we may have to handle it.

For that reason, we have the following code in collect2.cc:

#ifdef ENABLE_LTO
static enum lto_mode_d lto_mode = LTO_MODE_WHOPR;
#else
static enum lto_mode_d lto_mode = LTO_MODE_NONE;
#endif
...
        else if (startswith (argv[i], "-fno-lto"))
          lto_mode = LTO_MODE_NONE;
...
    if (use_plugin)
      lto_mode = LTO_MODE_NONE;
    if (no_partition && lto_mode == LTO_MODE_WHOPR)
      lto_mode = LTO_MODE_LTO;


However, this has the unintended side effect that "-fno-lto" also disables
handling the device side of offloading.

* * *

The question is how to handle this. Maybe something along the lines of the
following:


 if (ENABLE_OFFLOADING && lto_mode == LTO_MODE_NONE
     && (-fopenmp || -fopenacc) && !-foffload=disable)
   lto_mode = LTO_MODE_WHOPR;

             reply	other threads:[~2023-05-11 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 21:17 burnus at gcc dot gnu.org [this message]
2023-05-11 21:52 ` [Bug middle-end/109819] " jakub at gcc dot gnu.org
2023-05-11 21:59 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109819-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).