From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id AFDEA3858434; Wed, 17 May 2023 05:21:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFDEA3858434
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1684300912;
	bh=KZwr897yoj+3bpOlrxNSJbdtK1jMCTYWbo7zo4M2ayE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=uW1iheQ13mL9oBwuNCskhwc9KG84qDr1OGg2rgTgyi3LvtLmAugCKloF4+NeMAY0a
	 BfssObDdsLLcSfotk9IL+b7ZCXcLO00JzxSLBESJ31BLLDNXuppoYk20+3s4fWP9kA
	 hMQaLlXIbXL9NRH+t9t0oHw/SiKtuqgFuMqe3B/M=
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/109858] [14 Regression] r14-172 caused some
 SPEC2017 bmk to degrade on Power
Date: Wed, 17 May 2023 05:21:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: missed-optimization, ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: linkw at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109858-4-ZSQzVjk4o0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109858-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109858-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109858

--- Comment #9 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Kewen Lin from comment #6)
> (In reply to Hongtao.liu from comment #5)
> > (In reply to Kewen Lin from comment #3)
> > > (In reply to Hongtao.liu from comment #2)
> > > > Does https://gcc.gnu.org/pipermail/gcc-patches/2023-May/617431.html=
 help?
> > >=20
> > > Sorry, I just measured those degraded bmks with this fix, the results=
 showed
> > > it didn't help.
> >=20
> > Sorry for the inconvience, could you try again with attached patch.
> > The patch will still use GENERAL_REGS when hard_regno_mode_ok for mode =
and
> > GENERAL_REGS(which is the case in PR109610), hope it can also fix this
> > regression.
>=20
> Thanks for the prompt fix, I'll do the perf evaluation once the perf boxes
> get released (they are used by others now) and get back to you.

I re-evaluated all SPEC2017 bmks on Power9 and Power10 with this patch (r14=
-171
vs. r14-172 + this fix), and confirmed it does fix all three degradation fo=
und
before and it doesn't cause any new degradation (btw, all the >1% improveme=
nts
are gone as well, all the results are neutral).=