public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109877] Support for clang-style attributes is needed to parse Darwin SDK headers properly
Date: Tue, 16 May 2023 20:08:38 +0000 [thread overview]
Message-ID: <bug-109877-4-p4zpxjnuIk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109877-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109877
--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #4)
> (In reply to Andrew Pinski from comment #2)
> > This style of attributes is bad. Because the GNU style attribute is just
> > token(expression,expression,expression) it seems odd that they added these
> > kind of attributes without thinking maybe it would be rejected somewhere
> > else.
>
> To be precise, some attributes have the first argument an identifier rather
> than expression (e.g. mode/format/cleanup/access attribute).
> So, the macOS as first argument is acceptable, but not the second one.
As far as I can tell (and what my current implementation does) is to say that
everything in the inner parentheses cam be lexed/parsed in a manner specific to
the attribute ID.
so in:
availability(zzzz) the zzzz is parsed specifically to "availability"
and presumably:
another_attr(yyyy) could have a different set of rules.
As noted, we [at least, all I have spoken to] agree that this is bad (in
respect of deviating from GNU style without any other mechanism to
differentiate). However, once stuff is in the wild....
next prev parent reply other threads:[~2023-05-16 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 19:35 [Bug c++/109877] New: " iains at gcc dot gnu.org
2023-05-16 19:37 ` [Bug c++/109877] " iains at gcc dot gnu.org
2023-05-16 19:39 ` pinskia at gcc dot gnu.org
2023-05-16 19:50 ` iains at gcc dot gnu.org
2023-05-16 20:00 ` jakub at gcc dot gnu.org
2023-05-16 20:08 ` iains at gcc dot gnu.org [this message]
2023-05-16 20:26 ` jakub at gcc dot gnu.org
2023-05-17 7:09 ` rguenth at gcc dot gnu.org
2023-05-17 7:33 ` iains at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-109877-4-p4zpxjnuIk@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).