public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109884] __builtin_Xq returns _Float128 instead of __float128
Date: Wed, 17 May 2023 19:27:22 +0000	[thread overview]
Message-ID: <bug-109884-4-HZ8Udnse9W@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109884-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109884

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:1ce8a5472f4fd98318b5f3575797b56b814b8ad9

commit r13-7340-g1ce8a5472f4fd98318b5f3575797b56b814b8ad9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed May 17 20:59:54 2023 +0200

    i386: Fix up types in __builtin_{inf,huge_val,nan{,s},fabs,copysign}q
builtins [PR109884]

    When _Float128 support has been added to C++ for 13.1,  float128t_type_node
    tree has been added - in C float128_type_node and float128t_type_node is
    the same and represents both _Float128 and __float128, but in C++ they
    are distinct types which have different handling in the FEs.
    When doing that change, I mistakenly forgot to change FLOAT128 primitive
    type, which is used for the __builtin_{inf,huge_val,nan{,s},fabs,copysign}q
    builtins results and some of their arguments (and nothing else).

    The following patch fixes that.
    On ia64 we already use float128t_type_node for those builtins, pa while
    it has __float128 that type is the same as long double and so those
builtins
    have long double types and on powerpc seems we  don't have these builtins
    but instead define macros which map them to __builtin_*f128.  That will
    not work properly in C++, perhaps we should change those macros to be
    function-like and cast to __float128.

    2023-05-17  Jakub Jelinek  <jakub@redhat.com>

            PR c++/109884
            * config/i386/i386-builtin-types.def (FLOAT128): Use
            float128t_type_node rather than float128_type_node.

            * c-c++-common/pr109884.c: New test.

    (cherry picked from commit c8da62cfc6475c4b7213b2164c2c0ec8ea6d96b6)

  parent reply	other threads:[~2023-05-17 19:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  7:02 [Bug c++/109884] New: " g.peterhoff@t-online.de
2023-05-17  7:07 ` [Bug c++/109884] " pinskia at gcc dot gnu.org
2023-05-17  7:09 ` pinskia at gcc dot gnu.org
2023-05-17  7:17 ` g.peterhoff@t-online.de
2023-05-17  7:19 ` pinskia at gcc dot gnu.org
2023-05-17  7:20 ` redi at gcc dot gnu.org
2023-05-17  8:34 ` jakub at gcc dot gnu.org
2023-05-17  9:02 ` jakub at gcc dot gnu.org
2023-05-17  9:03 ` jakub at gcc dot gnu.org
2023-05-17 19:00 ` cvs-commit at gcc dot gnu.org
2023-05-17 19:27 ` cvs-commit at gcc dot gnu.org [this message]
2023-05-17 19:28 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109884-4-HZ8Udnse9W@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).