public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dimitri.gorokhovik at free dot fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109903] New: Register misallocation in hand-crafted asm insn, no diagnostics produced
Date: Thu, 18 May 2023 14:59:48 +0000	[thread overview]
Message-ID: <bug-109903-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109903

            Bug ID: 109903
           Summary: Register misallocation in hand-crafted asm insn, no
                    diagnostics produced
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimitri.gorokhovik at free dot fr
  Target Milestone: ---

For the source code:

#if NO_BUG
unsigned long f (unsigned long a)
{
  unsigned long v;

  asm ("mrs %[_1], pmccntr_eli0\n"
       "\tldr x1, [%[_2]]\n"
       : [_1] "=r" (v)
       : [_2] "r" (a)
       );

  return v;
}


#else // BUG

extern void g(unsigned long);
void f (unsigned long a)
{
  unsigned long v;

  asm ("mrs %[_1], pmccntr_eli0\n"
       "\tldr x1, [%[_2]]\n"
       : [_1] "=r" (v)
       : [_2] "r" (a)
       );

  g(v);
}

#endif

The asm output produced is:

## BUG
#APP
# 23 "bug.c" 1
        mrs %rdi, pmccntr_eli0
        ldr x1, [%rdi]

# 0 "" 2
#NO_APP


## NO_BUG
#APP
# 6 "bug.c" 1
        mrs %rax, pmccntr_eli0
        ldr x1, [%rdi]

# 0 "" 2
#NO_APP

As one can see, in the "NO BUG" case, the registers allocated to reading "the
counter" and to reading "memory", are different, whereas they are one and the
same in the "BUG" case.

This was obtained with today's trunk built for native compilation: gcc (GCC)
14.0.0 20230518 (experimental). 

The example was compiled as:
gcc -S -O3 -Wall -Wextra -o bug.S bug.c 

no diagnostic messages are produced.

Same was also observed with gcc-aarch64-none-linux toolchain 13.2 (from Arm
download page), so "target-related issue" might not be an entirely correct
classification for this.

             reply	other threads:[~2023-05-18 14:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:59 dimitri.gorokhovik at free dot fr [this message]
2023-05-18 15:02 ` [Bug target/109903] " pinskia at gcc dot gnu.org
2023-05-18 15:04 ` pinskia at gcc dot gnu.org
2023-05-18 15:05 ` pinskia at gcc dot gnu.org
2023-05-18 15:28 ` dimitri.gorokhovik at free dot fr
2023-05-18 15:50 ` pinskia at gcc dot gnu.org
2023-05-18 16:09 ` dimitri.gorokhovik at free dot fr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109903-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).