public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/109904] linking with -static flag generates undefined references
Date: Thu, 18 May 2023 21:08:24 +0000	[thread overview]
Message-ID: <bug-109904-4-zZgKSQKHZ8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109904-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109904

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Offloading doesn't work for 32-bit architectures, the offloading target needs
to have the same wordsize as the host and e.g. nvptx 32-bit support has been
deprecated and removed some years ago.
So, don't configure offloading for 32-bit architectures.

As for  adding -ldl automatically for -static linking, I think we should do:
2023-05-18  Jakub Jelinek  <jakub@redhat.com>

        PR libgomp/109904
        * configure.ac (link_gomp): Include also $DL_LIBS.
        * configure: Regenerated.

--- libgomp/configure.ac.jj     2023-05-15 19:12:35.138624638 +0200
+++ libgomp/configure.ac        2023-05-18 20:41:58.512501769 +0200
@@ -398,9 +398,9 @@ fi
 # which will force linkage against -lpthread (or equivalent for the system).
 # That's not 100% ideal, but about the best we can do easily.
 if test $enable_shared = yes; then
-  link_gomp="-lgomp %{static: $LIBS}"
+  link_gomp="-lgomp %{static: $LIBS${DL_LIBS:+ $DL_LIBS}}"
 else
-  link_gomp="-lgomp $LIBS"
+  link_gomp="-lgomp $LIBS${DL_LIBS:+ $DL_LIBS}"
 fi
 AC_SUBST(link_gomp)

--- libgomp/configure.jj        2023-05-15 19:12:35.138624638 +0200
+++ libgomp/configure   2023-05-18 20:42:12.703299052 +0200
@@ -16788,9 +16788,9 @@ fi
 # which will force linkage against -lpthread (or equivalent for the system).
 # That's not 100% ideal, but about the best we can do easily.
 if test $enable_shared = yes; then
-  link_gomp="-lgomp %{static: $LIBS}"
+  link_gomp="-lgomp %{static: $LIBS${DL_LIBS:+ $DL_LIBS}}"
 else
-  link_gomp="-lgomp $LIBS"
+  link_gomp="-lgomp $LIBS${DL_LIBS:+ $DL_LIBS}"
 fi

  parent reply	other threads:[~2023-05-18 21:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 18:07 [Bug fortran/109904] New: " Gary.White at ColoState dot edu
2023-05-18 18:11 ` [Bug libgomp/109904] " pinskia at gcc dot gnu.org
2023-05-18 18:14 ` pinskia at gcc dot gnu.org
2023-05-18 18:28 ` Gary.White at ColoState dot edu
2023-05-18 18:33 ` pinskia at gcc dot gnu.org
2023-05-18 18:36 ` Gary.White at ColoState dot edu
2023-05-18 20:53 ` Gary.White at ColoState dot edu
2023-05-18 20:59 ` pinskia at gcc dot gnu.org
2023-05-18 21:02 ` Gary.White at ColoState dot edu
2023-05-18 21:06 ` pinskia at gcc dot gnu.org
2023-05-18 21:08 ` jakub at gcc dot gnu.org [this message]
2023-05-19  8:16 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109904-4-zZgKSQKHZ8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).