public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/109921] [13 Regression] c++17/floating_from_chars.cc: compile error: ‘from_chars_strtod’ was not declared in this scope
Date: Wed, 19 Jul 2023 23:31:35 +0000	[thread overview]
Message-ID: <bug-109921-4-G3Fka8V14R@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109921-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109921

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:cd2f934bb09c04e62beb8eb5421467184598983b

commit r13-7593-gcd2f934bb09c04e62beb8eb5421467184598983b
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 25 10:32:33 2023 +0100

    libstdc++: Fix preprocessor conditions for std::from_chars [PR109921]

    We use the from_chars_strtod function with __strtof128 to read a
    _Float128 value, but from_chars_strtod is not defined unless uselocale
    is available. This can lead to compilation failures for some targets,
    because we try to define the _Float128 overload in terms of a
    non-existing from_chars_strtod function.

    Only try to use __strtof128 if uselocale is available and therefore we
    can use the from_chars_strtod function template.

    This is a simpler change than r14-1431-g7037e7b6e4ac41 on trunk, because
    that caused unwanted ABI regressions (PR libstdc++/110077).

    libstdc++-v3/ChangeLog:

            PR libstdc++/109921
            * src/c++17/floating_from_chars.cc (USE_STRTOF128_FOR_FROM_CHARS):
            Only define when USE_STRTOD_FOR_FROM_CHARS is also defined.
            (USE_STRTOD_FOR_FROM_CHARS): Do not undefine when long double is
            binary64.
            (from_chars(const char*, const char*, double&, chars_format)):
            Check __LDBL_MANT_DIG__ == __DBL_MANT_DIG__ here.

  parent reply	other threads:[~2023-07-19 23:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21 10:02 [Bug libstdc++/109921] New: " br015 at umbiko dot net
2023-05-24 11:16 ` [Bug libstdc++/109921] " redi at gcc dot gnu.org
2023-05-24 13:01 ` redi at gcc dot gnu.org
2023-05-25  8:31 ` br015 at umbiko dot net
2023-05-31 12:21 ` cvs-commit at gcc dot gnu.org
2023-05-31 12:24 ` redi at gcc dot gnu.org
2023-05-31 19:57 ` cvs-commit at gcc dot gnu.org
2023-07-19 19:53 ` redi at gcc dot gnu.org
2023-07-19 22:43 ` [Bug libstdc++/109921] [13 Regression] " cvs-commit at gcc dot gnu.org
2023-07-19 23:31 ` cvs-commit at gcc dot gnu.org [this message]
2023-07-19 23:33 ` redi at gcc dot gnu.org
2023-07-20 11:57 ` redi at gcc dot gnu.org
2023-07-21 13:04 ` redi at gcc dot gnu.org
2023-07-22  6:05 ` br015 at umbiko dot net
2023-07-22  9:01 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109921-4-G3Fka8V14R@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).