public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109943] [13/14 Regression] Missed Dead Code Elimination when using __builtin_unreachable since r13-6834-g41ade3399bd
Date: Fri, 12 Jan 2024 13:50:24 +0000	[thread overview]
Message-ID: <bug-109943-4-sC1fv5lMTK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109943-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109943

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
With the __builtin_unreachable present (thus g >= 0) we simplify
(int)(char)d to d & 255 which causes the VN difference:

 Value numbering stmt = _9 = (int) _8;
+d.4_7 is available for d.4_7
+_2 is available for _2
 Setting value number of _9 to _9 (changed)
-Making available beyond BB2 _9 for value _9
-Value numbering stmt = _10 = (int) d.4_7;
-Setting value number of _10 to _9 (changed)
+Making available beyond BB4 _9 for value _9
+Value numbering stmt = _10 = b.3_6 & 255;
+_2 is available for _2
+Setting value number of _10 to _10 (changed)
+Making available beyond BB4 _10 for value _10
 Value numbering stmt = _11 = _9 % _10;

in particular we have

  _2 = b;
  b.3_6 = b;
  d.4_7 = (char) b.3_6;
  _8 = (char) _2;
  _9 = (int) _8;
  _10 = (int) d.4_7;
  _11 = _9 % _10;

vs.

  _2 = b;
  b.3_6 = b;
  d.4_7 = (char) b.3_6;
  _8 = (char) _2;
  if (d.4_7 <= 0)
    goto <bb 3>; [0.00%]
  else
    goto <bb 4>; [100.00%]

  <bb 3> [count: 0]:
  __builtin_unreachable ();

  <bb 4> [local count: 1073741824]:
  _9 = (int) _8;
  _10 = b.3_6 & 255;
  _11 = _9 % _10;

where the trivial equivalence is no longer visible.

  parent reply	other threads:[~2024-01-12 13:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 13:30 [Bug tree-optimization/109943] New: " theodort at inf dot ethz.ch
2023-05-23 15:56 ` [Bug tree-optimization/109943] " rguenth at gcc dot gnu.org
2023-06-20 16:34 ` theodort at inf dot ethz.ch
2023-07-27  9:26 ` rguenth at gcc dot gnu.org
2023-08-21 23:09 ` pinskia at gcc dot gnu.org
2024-01-12 13:50 ` rguenth at gcc dot gnu.org [this message]
2024-01-12 13:52 ` rguenth at gcc dot gnu.org
2024-05-21  9:15 ` [Bug tree-optimization/109943] [13/14/15 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109943-4-sC1fv5lMTK@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).