public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/109948] [13/14 Regression] ICE(segfault) in gfc_expression_rank() from gfc_op_rank_conformable()
Date: Wed, 31 May 2023 18:39:01 +0000 [thread overview]
Message-ID: <bug-109948-4-4rQ1DBj4UR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109948-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109948
--- Comment #16 from anlauf at gcc dot gnu.org ---
(In reply to Paul Thomas from comment #15)
> Created attachment 55225 [details]
> Fix for this PR
>
> The attached patch substantially tidies up parse_associate and fixes:
LGTM!
I was close to proposing a hack for gfc_expression_rank that checks
whether the variable's select_type_temporary, select_rank_temporary and
associate_var attributes to decide which ref to evaluate. But your
patch seems to be a much better approach.
BTW: after your patch, the attribute assoc->rankguessed is no longer set.
It is tested in two locations in resolve_assoc_var(resolve.cc), where
it might be removed after your fix.
next prev parent reply other threads:[~2023-05-31 18:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 0:20 [Bug fortran/109948] New: " rimvydas.jas at gmail dot com
2023-05-24 17:05 ` [Bug fortran/109948] " rimvydas.jas at gmail dot com
2023-05-24 17:14 ` [Bug fortran/109948] [13/14 Regression] " anlauf at gcc dot gnu.org
2023-05-24 17:19 ` anlauf at gcc dot gnu.org
2023-05-24 18:35 ` anlauf at gcc dot gnu.org
2023-05-25 3:07 ` rimvydas.jas at gmail dot com
2023-05-25 7:36 ` rguenth at gcc dot gnu.org
2023-05-25 18:34 ` anlauf at gcc dot gnu.org
2023-05-25 19:20 ` anlauf at gcc dot gnu.org
2023-05-26 9:47 ` pault at gcc dot gnu.org
2023-05-26 10:15 ` pault at gcc dot gnu.org
2023-05-26 10:34 ` mikael at gcc dot gnu.org
2023-05-26 21:00 ` anlauf at gcc dot gnu.org
2023-05-26 21:25 ` anlauf at gcc dot gnu.org
2023-05-26 21:35 ` anlauf at gcc dot gnu.org
2023-05-30 8:59 ` pault at gcc dot gnu.org
2023-05-31 17:11 ` pault at gcc dot gnu.org
2023-05-31 18:39 ` anlauf at gcc dot gnu.org [this message]
2023-05-31 19:39 ` mikael at gcc dot gnu.org
2023-06-02 7:42 ` cvs-commit at gcc dot gnu.org
2023-06-02 9:13 ` pault at gcc dot gnu.org
2023-06-02 9:16 ` pault at gcc dot gnu.org
2023-08-27 8:51 ` cvs-commit at gcc dot gnu.org
2023-09-07 16:04 ` anlauf at gcc dot gnu.org
2023-09-07 16:06 ` anlauf at gcc dot gnu.org
2023-09-28 8:57 ` anlauf at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-109948-4-4rQ1DBj4UR@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).