From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id C1F473858D3C; Fri,  2 Jun 2023 09:13:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1F473858D3C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1685697211;
	bh=aPpQz8XFnZAjJ50siLLA0SuPpOuZIn+Wgl2VwZ01PTU=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=yhMrEl1iLcwdfoJIX71YeHrNFNPrh8K6E3+WfrszfG+ulCUvJGer2zUJ9YtnUta8V
	 QzJ3+ReGM+aAw+uzYdJR+5/Rorog0ir7dJDpD/CZwBKGNA/RYqXZpURIfTuTfj1FIG
	 6izRTIm8kx7/t8uSDEdQhxTwY6+zFs0DLcaN7OSk=
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/109948] [13/14 Regression] ICE(segfault) in
 gfc_expression_rank() from gfc_op_rank_conformable()
Date: Fri, 02 Jun 2023 09:13:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 13.1.1
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: pault at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109948-4-QCXV38Fx9N@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109948-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109948-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109948

--- Comment #19 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to anlauf from comment #16)
> (In reply to Paul Thomas from comment #15)
> > Created attachment 55225 [details]
> > Fix for this PR
> >=20
> > The attached patch substantially tidies up parse_associate and fixes:
>=20
> LGTM!
>=20
> I was close to proposing a hack for gfc_expression_rank that checks
> whether the variable's select_type_temporary, select_rank_temporary and
> associate_var attributes to decide which ref to evaluate.  But your
> patch seems to be a much better approach.
>=20
> BTW: after your patch, the attribute assoc->rankguessed is no longer set.
> It is tested in two locations in resolve_assoc_var(resolve.cc), where
> it might be removed after your fix.

On the latter =3D> yes indeed!

I see that I had a fix for pr109451, which was never submitted. I am going =
to
shake the dust off the patch and will set about removing rankguessed.

Thanks

Paul=