public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/109973] [13/14 Regression] Wrong code for AVX2 since 13.1 by combining VPAND and VPTEST since r13-2006-ga56c1641e9d25e Date: Sun, 04 Jun 2023 11:01:39 +0000 [thread overview] Message-ID: <bug-109973-4-8hDLZoUjBH@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109973-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109973 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>: https://gcc.gnu.org/g:8ab9fb6b8e05cf9acca7bd8282979ede53524cf1 commit r14-1528-g8ab9fb6b8e05cf9acca7bd8282979ede53524cf1 Author: Roger Sayle <roger@nextmovesoftware.com> Date: Sun Jun 4 11:59:32 2023 +0100 PR target/110083: Fix-up REG_EQUAL notes on COMPARE in STV. This patch fixes PR target/110083, an ICE-on-valid regression exposed by my recent PTEST improvements (to address PR target/109973). The latent bug (admittedly mine) is that the scalar-to-vector (STV) pass doesn't update or delete REG_EQUAL notes attached to COMPARE instructions. As a result the operands of COMPARE would be mismatched, with the register transformed to V1TImode, but the immediate operand left as const_wide_int, which is valid for TImode but not V1TImode. This remained latent when the STV conversion converted the mode of the COMPARE to CCmode, with later passes recognizing the REG_EQUAL note is obviously invalid as the modes didn't match, but now that we (correctly) preserve the CCZmode on COMPARE, the mismatched operand modes trigger a sanity checking ICE downstream. Fixed by updating (or deleting) any REG_EQUAL notes in convert_compare. Before: (expr_list:REG_EQUAL (compare:CCZ (reg:V1TI 119 [ ivin.29_38 ]) (const_wide_int 0x80000000000000000000000000000000)) After: (expr_list:REG_EQUAL (compare:CCZ (reg:V1TI 119 [ ivin.29_38 ]) (const_vector:V1TI [ (const_wide_int 0x80000000000000000000000000000000) ])) 2023-06-04 Roger Sayle <roger@nextmovesoftware.com> gcc/ChangeLog PR target/110083 * config/i386/i386-features.cc (scalar_chain::convert_compare): Update or delete REG_EQUAL notes, converting CONST_INT and CONST_WIDE_INT immediate operands to a suitable CONST_VECTOR. gcc/testsuite/ChangeLog PR target/110083 * gcc.target/i386/pr110083.c: New test case.
next prev parent reply other threads:[~2023-06-04 11:01 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-26 0:38 [Bug rtl-optimization/109973] New: Wrong code for AVX2 since 13.1 by combining VPAND and VPTEST benjsith at gmail dot com 2023-05-26 0:42 ` [Bug rtl-optimization/109973] " benjsith at gmail dot com 2023-05-26 0:47 ` [Bug target/109973] [13/14 Regression] " pinskia at gcc dot gnu.org 2023-05-26 6:31 ` [Bug target/109973] [13/14 Regression] Wrong code for AVX2 since 13.1 by combining VPAND and VPTEST since r13-2006-ga56c1641e9d25e rguenth at gcc dot gnu.org 2023-05-26 6:56 ` jakub at gcc dot gnu.org 2023-05-26 12:06 ` benjsith at gmail dot com 2023-05-29 18:24 ` roger at nextmovesoftware dot com 2023-05-30 13:44 ` cvs-commit at gcc dot gnu.org 2023-06-01 14:12 ` cvs-commit at gcc dot gnu.org 2023-06-03 18:01 ` benjsith at gmail dot com 2023-06-04 11:01 ` cvs-commit at gcc dot gnu.org [this message] 2023-06-22 6:44 ` cvs-commit at gcc dot gnu.org 2023-07-03 13:28 ` [Bug target/109973] [13 " roger at nextmovesoftware dot com 2023-07-03 13:43 ` jakub at gcc dot gnu.org 2023-07-20 7:28 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109973-4-8hDLZoUjBH@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).