From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 354393858C78; Mon, 29 May 2023 18:05:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 354393858C78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685383540; bh=mDFWfnGYxlensA/pqpaYXyrOlsoTHfmYLwBc0hxSS5k=; h=From:To:Subject:Date:In-Reply-To:References:From; b=bSgyjQrwUFzE2KraRGxx0qSVbIZheCz+09oWRdVFw+KUJVfzH7oddf8BaskaGlYN2 hV6XQo7IPLxX7nTU5Ng6y5Yy4RLI87LHL1e91sp4U8Vzlgq02XoTbaC8XSehlQGoju a0oVC+kzNHK9RabKouiawfHEoLoECyuOT2zAFgSU= From: "burnus at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/109999] [OpenMP] Bogus error message: talks about '"#pragma omp" clause' instead of '"target" clause Date: Mon, 29 May 2023 18:05:39 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: diagnostic, openmp X-Bugzilla-Severity: normal X-Bugzilla-Who: burnus at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109999 --- Comment #2 from Tobias Burnus --- Created attachment 55188 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D55188&action=3Dedit Patch implementing the wording change "'#pragma omp/acc' clause" =E2=86=92 = "an OpenMP/ACC clause" (untested) I think the following wording is clearer, i.e. - instead of: error: expected =E2=80=98#pragma omp=E2=80=99 clause before =E2=80=98uses= _allocators=E2=80=99 + now: error: expected an OpenMP clause before =E2=80=98uses_allocators=E2=80=99 (I could imagine even a more helpful wording in this case, but I think that change is sufficient; The "before ..." (here: "before %qE") is appended via c_parser_error =E2=86=92 c_parser_error_richloc =E2=86=92 c_parse_error.)=