public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/110011] -mfull-toc (-mfp-in-toc) yields incorrect _Float128 constants on power9
Date: Tue, 30 May 2023 08:09:15 +0000 [thread overview]
Message-ID: <bug-110011-4-ncLGRF994b@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110011-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110011
--- Comment #5 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Vincent Lefèvre from comment #4)
> (In reply to Kewen Lin from comment #3)
> > Thanks for reporting, this exposes one issue that: when encoding KFmode
> > constant into toc, it uses the format for the current long double, it could
> > be wrong if the current long double is with IBM format instead of IEEE
> > format. I have a patch.
>
> OK, but why does an explicit `-mfull-toc` make this issue appear while this
> is documented to be the default?
Good question, the reason is that we actually don't put fp in toc for
-mcmodel=medium if -mfp-in-toc (or -mfull-toc) isn't explicitly specified,
since we can address them efficiently even outside the TOC.
Some codes like:
if (rs6000_current_cmodel != CMODEL_SMALL)
{
if (!OPTION_SET_P (TARGET_NO_FP_IN_TOC))
TARGET_NO_FP_IN_TOC = rs6000_current_cmodel == CMODEL_MEDIUM;
if (!OPTION_SET_P (TARGET_NO_SUM_IN_TOC))
TARGET_NO_SUM_IN_TOC = 0;
}
I think you can still see the wrong constant if not specifying -mfull-toc but
with the specified -mcmodel=small (or large). Anyway, IMHO the documentation
also needs some updates.
next prev parent reply other threads:[~2023-05-30 8:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 0:32 [Bug target/110011] New: -mfull-toc " vincent-gcc at vinc17 dot net
2023-05-28 3:41 ` [Bug target/110011] -mfull-toc (-mfp-in-toc) " pinskia at gcc dot gnu.org
2023-05-28 3:54 ` pinskia at gcc dot gnu.org
2023-05-30 6:47 ` linkw at gcc dot gnu.org
2023-05-30 7:51 ` vincent-gcc at vinc17 dot net
2023-05-30 8:09 ` linkw at gcc dot gnu.org [this message]
2023-05-30 8:11 ` linkw at gcc dot gnu.org
2023-06-12 6:10 ` cvs-commit at gcc dot gnu.org
2023-06-19 9:29 ` cvs-commit at gcc dot gnu.org
2023-06-20 3:20 ` cvs-commit at gcc dot gnu.org
2023-06-20 3:21 ` cvs-commit at gcc dot gnu.org
2023-06-20 8:24 ` cvs-commit at gcc dot gnu.org
2023-06-20 8:27 ` LpSolit at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-110011-4-ncLGRF994b@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).