public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/110018] Missing vectorizable_conversion(unsigned char -> double) for BB vectorizer
Date: Mon, 26 Jun 2023 07:30:34 +0000	[thread overview]
Message-ID: <bug-110018-4-YhxDRqNud3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110018-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110018

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:77a50c772771f681085922b493922516c3c03e9a

commit r14-2085-g77a50c772771f681085922b493922516c3c03e9a
Author: liuhongt <hongtao.liu@intel.com>
Date:   Sun Jun 25 11:35:09 2023 +0800

    Don't use intermiediate type for FIX_TRUNC_EXPR when ftrapping-math.

    > > Hmm, good question.  GENERIC has a direct truncation to unsigned char
    > > for example, the C standard generally says if the integral part cannot
    > > be represented then the behavior is undefined.  So I think we should be
    > > safe here (0x1.0p32 doesn't fit an int).
    >
    > We should be following Annex F (unspecified value plus "invalid"
exception
    > for out-of-range floating-to-integer conversions rather than undefined
    > behavior).  But we don't achieve that very well at present (see bug 93806
    > comments 27-29 for examples of how such conversions produce wobbly
    > values).

    That would mean guarding this with !flag_trapping_math would be the
appropriate
    thing to do.

    gcc/ChangeLog:

            PR tree-optimization/110371
            PR tree-optimization/110018
            * tree-vect-stmts.cc (vectorizable_conversion): Don't use
            intermiediate type for FIX_TRUNC_EXPR when ftrapping-math.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr110018-1.c: Add -fno-trapping-math to
dg-options.
            * gcc.target/i386/pr110018-2.c: Ditto.

  parent reply	other threads:[~2023-06-26  7:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29  2:35 [Bug middle-end/110018] New: " crazylht at gmail dot com
2023-05-29  3:28 ` [Bug middle-end/110018] " pinskia at gcc dot gnu.org
2023-05-29  5:53 ` crazylht at gmail dot com
2023-05-29  6:14 ` crazylht at gmail dot com
2023-05-30  7:57 ` rguenth at gcc dot gnu.org
2023-05-30  9:50 ` crazylht at gmail dot com
2023-06-21  2:33 ` cvs-commit at gcc dot gnu.org
2023-06-21  2:38 ` crazylht at gmail dot com
2023-06-21 14:35 ` cvs-commit at gcc dot gnu.org
2023-06-26  7:30 ` cvs-commit at gcc dot gnu.org [this message]
2023-06-26  7:49 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110018-4-YhxDRqNud3@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).