public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation
@ 2023-05-30 18:24 dcb314 at hotmail dot com
  2023-05-30 18:24 ` [Bug target/110041] " dcb314 at hotmail dot com
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2023-05-30 18:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110041

            Bug ID: 110041
           Summary: gcc/config/i386/i386-expand.cc:23394:5: warning:
                    misleading indentation
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I just tried a build of gcc trunk with clang. It said:

gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]

git blame says:

52ff3f7b86 (Uros Bizjak              2023-05-25 19:40:26 +0200 23394)     if
(code != MULT && op2vec)

It might be worth tidying this up.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110041] gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation
  2023-05-30 18:24 [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation dcb314 at hotmail dot com
@ 2023-05-30 18:24 ` dcb314 at hotmail dot com
  2023-05-30 18:50 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2023-05-30 18:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110041

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uros at gcc dot gnu.org

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Adding author of code.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110041] gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation
  2023-05-30 18:24 [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation dcb314 at hotmail dot com
  2023-05-30 18:24 ` [Bug target/110041] " dcb314 at hotmail dot com
@ 2023-05-30 18:50 ` cvs-commit at gcc dot gnu.org
  2023-05-30 18:55 ` ubizjak at gmail dot com
  2023-05-31  5:59 ` egallager at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-30 18:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110041

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:2720bbd597f56742a17119dfe80edc2ba86af255

commit r14-1416-g2720bbd597f56742a17119dfe80edc2ba86af255
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Tue May 30 20:38:20 2023 +0200

    i386: Fix misleading identation in i386-expand.cc [PR110041]

    gcc/ChangeLog:

            PR target/110041
            * config/i386/i386-expand.cc (ix86_expand_vecop_qihi2):
            Fix misleading identation.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110041] gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation
  2023-05-30 18:24 [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation dcb314 at hotmail dot com
  2023-05-30 18:24 ` [Bug target/110041] " dcb314 at hotmail dot com
  2023-05-30 18:50 ` cvs-commit at gcc dot gnu.org
@ 2023-05-30 18:55 ` ubizjak at gmail dot com
  2023-05-31  5:59 ` egallager at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: ubizjak at gmail dot com @ 2023-05-30 18:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110041

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
            Version|unknown                     |14.0
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0
             Target|                            |x86

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110041] gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation
  2023-05-30 18:24 [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation dcb314 at hotmail dot com
                   ` (2 preceding siblings ...)
  2023-05-30 18:55 ` ubizjak at gmail dot com
@ 2023-05-31  5:59 ` egallager at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: egallager at gcc dot gnu.org @ 2023-05-31  5:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110041

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #4 from Eric Gallager <egallager at gcc dot gnu.org> ---
GCC also has its own -Wmisleading-indentation flag; I wonder why that didn't
catch this?

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-31  5:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 18:24 [Bug target/110041] New: gcc/config/i386/i386-expand.cc:23394:5: warning: misleading indentation dcb314 at hotmail dot com
2023-05-30 18:24 ` [Bug target/110041] " dcb314 at hotmail dot com
2023-05-30 18:50 ` cvs-commit at gcc dot gnu.org
2023-05-30 18:55 ` ubizjak at gmail dot com
2023-05-31  5:59 ` egallager at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).