public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "david.faust at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/110073] [14 regression] btfout.cc format errors break bootstrap
Date: Thu, 01 Jun 2023 16:50:43 +0000	[thread overview]
Message-ID: <bug-110073-4-7xkGP8XGQU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110073-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110073

--- Comment #1 from David Faust <david.faust at oracle dot com> ---
Created attachment 55234
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55234&action=edit
alternate proposed patch

Thank you for catching this, and for the fix!

With the proposed patch on linux x86_64 I see the following:

../../../gcc/gcc/btfout.cc: In function ‘void
btf_asm_func_type(ctf_container_ref, ctf_dtdef_ref, size_t)’:
../../../gcc/gcc/btfout.cc:952:31: warning: format ‘%u’ expects argument of
type ‘unsigned int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’}
[-Wformat=]
  952 |                        "TYPE %u BTF_KIND_FUNC '%s'",
      |                              ~^
      |                               |
      |                               unsigned int
      |                              %lu
  953 |                        num_types_added + num_vars_added + 1 + i,
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                             |
      |                                                             size_t {aka
long unsigned int}

I believe %zu instead of %u should work.

Alternatively, a small refactor to the offending code makes it behave in line
with the other functions (to properly use a ctf_id_t, and then PRIu64 as in
your patch). But I haven't verified this on solaris/x86 yet.

  parent reply	other threads:[~2023-06-01 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 10:05 [Bug debug/110073] New: " ro at gcc dot gnu.org
2023-06-01 10:05 ` [Bug debug/110073] " ro at gcc dot gnu.org
2023-06-01 16:50 ` david.faust at oracle dot com [this message]
2023-06-02  8:38 ` iains at gcc dot gnu.org
2023-06-02 12:58 ` iains at gcc dot gnu.org
2023-06-02 15:49 ` david.faust at oracle dot com
2023-06-02 16:24 ` iains at gcc dot gnu.org
2023-06-02 16:32 ` david.faust at oracle dot com
2023-06-02 16:33 ` cvs-commit at gcc dot gnu.org
2023-06-02 16:35 ` acoplan at gcc dot gnu.org
2023-06-02 16:41 ` david.faust at oracle dot com
2023-06-29  8:00 ` iains at gcc dot gnu.org
2023-06-29  8:47 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110073-4-7xkGP8XGQU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).